Remove exceptions from control flow

Author: mythz

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -689,7 +689,8 @@ public virtual void PrepareParameterizedUpdateStatement<T>(IDbCommand cmd, IColl
                 }
             }
 
-            if (sql.Length < 1) throw new InvalidOperationException("No columns to update");
+            if (sql.Length < 1) 
+                return;
 
             cmd.CommandText = string.Format("UPDATE {0} SET {1} {2}",
                 GetQuotedTableName(modelDef), sql, (sqlFilter.Length > 0 ? "WHERE " + sqlFilter : ""));

src/ServiceStack.OrmLite/OrmLiteWriteExtensions.cs

@@ -370,15 +370,9 @@ internal static int Update<T>(this IDbCommand dbCmd, T obj)
             if (OrmLiteConfig.UpdateFilter != null)
                 OrmLiteConfig.UpdateFilter(dbCmd, obj);
 
-            try
-            {
-                OrmLiteConfig.DialectProvider.PrepareParameterizedUpdateStatement<T>(dbCmd);
-            }
-            catch (InvalidOperationException ex)
-            {
-                Log.Debug(ex.Message);
+            OrmLiteConfig.DialectProvider.PrepareParameterizedUpdateStatement<T>(dbCmd);
+            if (dbCmd.CommandText == null)
                 return 0;
-            }
 
             OrmLiteConfig.DialectProvider.SetParameterValues<T>(dbCmd, obj);
 
@@ -402,15 +396,9 @@ internal static int UpdateAll<T>(this IDbCommand dbCmd, IEnumerable<T> objs)
 
                 var dialectProvider = OrmLiteConfig.DialectProvider;
 
-                try
-                {
-                    dialectProvider.PrepareParameterizedUpdateStatement<T>(dbCmd);
-                }
-                catch (InvalidOperationException ex)
-                {
-                    Log.Debug(ex.Message);
-                    return count;
-                }
+                dialectProvider.PrepareParameterizedUpdateStatement<T>(dbCmd);
+                if (dbCmd.CommandText == null)
+                    return 0;
 
                 foreach (var obj in objs)
                 {

tests/ServiceStack.OrmLite.Tests/OrmLiteSaveTests.cs

@@ -227,10 +227,13 @@ public void Can_Save_Update_Into_Table_With_Id_Only()
         {
             using (var db = OpenDbConnection())
             {
-                db.CreateTable<ModelWithIdOnly>(true);
+                db.DropAndCreateTable<ModelWithIdOnly>();
+
                 db.Save(new ModelWithIdOnly(1));
 
                 db.Save(new ModelWithIdOnly(1));
+
+                db.Update(new ModelWithIdOnly(1));
             }
         }
     }