No need to deoptimize OrderBy if query has specified TOP/Take

Author: mythz

src/ServiceStack.OrmLite.SqlServer/SqlServerOrmLiteDialectProvider.cs

@@ -463,7 +463,7 @@ public static string UseAliasesOrStripTablePrefixes(string selectExpression)
 
         public override string GetLoadChildrenSubSelect<From>(ModelDefinition modelDef, SqlExpression<From> expr)
         {
-            if (!expr.OrderByExpression.IsNullOrEmpty())
+            if (!expr.OrderByExpression.IsNullOrEmpty() && expr.Rows == null)
             {
                 expr.Select(this.GetQuotedColumnName(modelDef, modelDef.PrimaryKey))
                     .ClearLimits()

tests/ServiceStack.OrmLite.Tests/LoadReferencesJoinTests.cs

@@ -618,7 +618,7 @@ public void Can_load_references_with_OrderBy_and_Paging()
 
             // Select the Parent.Id == 2.  LoadSelect should populate the child, but doesn't.
             var q = db.From<Parent>()
-                .Limit(0, 1)
+                .Take(1)
                 .OrderByDescending<Parent>(p => p.Id);
 
             var results = db.LoadSelect(q);
@@ -627,6 +627,15 @@ public void Can_load_references_with_OrderBy_and_Paging()
             Assert.That(results[0].Child, Is.Not.Null);
             Assert.That(results[0].Child.Value, Is.EqualTo("Lolz"));
 
+            q = db.From<Parent>()
+                .Skip(1)
+                .OrderBy<Parent>(p => p.Id);
+
+            results = db.LoadSelect(q);
+
+            Assert.That(results.Count, Is.EqualTo(1));
+            Assert.That(results[0].Child, Is.Not.Null);
+            Assert.That(results[0].Child.Value, Is.EqualTo("Lolz"));
             results.PrintDump();
         }
     }