Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Commit 6b597d4

Browse files
committed
Change usage of old CreateInstance to use newer ConverTo<T> API
1 parent a4fcb73 commit 6b597d4

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

src/ServiceStack.OrmLite/Async/ReadExpressionCommandExtensionsAsync.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ internal static Task<long> RowCountAsync(this IDbCommand dbCmd, string sql, Canc
155155
internal static Task<T> ExprConvertToAsync<T>(this IDataReader dataReader, IOrmLiteDialectProvider dialectProvider, CancellationToken token)
156156
{
157157
return dialectProvider.ReaderRead(dataReader,
158-
() => dataReader.CreateInstance<T>(dialectProvider), token);
158+
() => dataReader.ConvertTo<T>(dialectProvider), token);
159159
}
160160

161161
internal static Task<List<T>> ExprConvertToListAsync<T>(this IDataReader dataReader, IOrmLiteDialectProvider dialectProvider, CancellationToken token)

src/ServiceStack.OrmLite/Expressions/ReadExpressionCommandExtensions.cs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -154,22 +154,10 @@ internal static T ExprConvertTo<T>(this IDataReader dataReader, IOrmLiteDialectP
154154
{
155155
using (dataReader)
156156
{
157-
return dataReader.Read() ? dataReader.CreateInstance<T>(dialectProvider) : default(T);
157+
return dataReader.Read() ? dataReader.ConvertTo<T>(dialectProvider) : default(T);
158158
}
159159
}
160160

161-
internal static T CreateInstance<T>(this IDataReader dataReader, IOrmLiteDialectProvider dialectProvider)
162-
{
163-
var row = OrmLiteUtilExtensions.CreateInstance<T>();
164-
var fieldDefs = ModelDefinition<T>.Definition.AllFieldDefinitionsArray;
165-
foreach (var fieldDef in fieldDefs)
166-
{
167-
var index = dataReader.FindColumnIndex(dialectProvider, fieldDef);
168-
dialectProvider.SetDbValue(fieldDef, dataReader, index, row);
169-
}
170-
return row;
171-
}
172-
173161
internal static List<T> ExprConvertToList<T>(this IDataReader dataReader, IOrmLiteDialectProvider dialectProvider)
174162
{
175163
var fieldDefs = ModelDefinition<T>.Definition.AllFieldDefinitionsArray;

0 commit comments

Comments
 (0)