Add support for composite index of fields with spaces

Author: mythz

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -1155,10 +1155,17 @@ public virtual List<string> ToCreateIndexStatements(Type tableType)
                     if (sb.Length > 0)
                         sb.Append(", ");
 
-                    var parts = fieldName.SplitOnFirst(' ');
-                    sb.Append(GetQuotedColumnName(parts[0]))
-                      .Append(' ')
-                      .Append(parts.Length > 1 ? parts[1] : "ASC");
+                    var parts = fieldName.SplitOnLast(' ');
+                    if (parts.Length == 2 && (parts[1].ToLower().StartsWith("desc") || parts[1].ToLower().StartsWith("asc")))
+                    {
+                        sb.Append(GetQuotedColumnName(parts[0]))
+                          .Append(' ')
+                          .Append(parts[1]);
+                    }
+                    else
+                    {
+                        sb.Append(GetQuotedColumnName(fieldName));
+                    }
                 }
 
                 sqlIndexes.Add(

tests/ServiceStack.OrmLite.Tests/OrmLiteCreateTableWithIndexesTests.cs

@@ -78,6 +78,25 @@ public void Can_create_ModelWithCompositeIndexFieldsDesc_table()
             }
         }
 
+        [Test]
+        public void Can_create_ModelWithCompositeIndexOnFieldSpacesDesc_table()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.CreateTable<ModelWithCompositeIndexOnFieldSpacesDesc>(true);
+                db.GetLastSql().Print();
+
+                var sql = OrmLiteConfig.DialectProvider.ToCreateIndexStatements(typeof(ModelWithCompositeIndexOnFieldSpacesDesc)).Join();
+
+                var compositeName = "idx_modelwithcompositeindexonfieldspacesdesc_field_field";
+
+                if (Dialect == Dialect.Oracle || Dialect == Dialect.Firebird)
+                    compositeName = OrmLiteConfig.DialectProvider.NamingStrategy.ApplyNameRestrictions(compositeName).ToLower();
+
+                Assert.That(sql, Is.StringContaining(compositeName));
+            }
+        }
+
         [Test]
         public void Can_create_ModelWithNamedCompositeIndex_table()
         {

tests/ServiceStack.OrmLite.Tests/Shared/ModelWithCompositeIndexFields.cs

@@ -37,4 +37,16 @@ public class ModelWithCompositeIndexFieldsDesc
 
         public string Composite2 { get; set; }
     }
+
+    [CompositeIndex("Field WithSpace1", "Field WithSpace2 DESC")]
+    public class ModelWithCompositeIndexOnFieldSpacesDesc
+    {
+        public string Id { get; set; }
+
+        [Alias("Field WithSpace1")]
+        public string FieldWithSpace1 { get; set; }
+
+        [Alias("Field WithSpace2")]
+        public string FieldWithSpace2 { get; set; }
+    }
 }