Add fix for merging Nested SqlExpression Issue

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -1739,14 +1739,15 @@ protected string ConvertInExpressionToSql(MethodCallExpression m, object quotedC
             if (exprArg != null)
             {
                 var subSelect = exprArg.ToSelectStatement();
+                var renameParams = new List<Tuple<string,string>>();
                 foreach (var p in exprArg.Params)
                 {
                     var oldName = p.ParameterName;
                     var newName = DialectProvider.GetParam(Params.Count.ToString());
                     if (oldName != newName)
                     {
                         var pClone = DialectProvider.CreateParam().PopulateWith(p);
-                        subSelect = subSelect.Replace(oldName, newName);
+                        renameParams.Add(Tuple.Create(oldName, newName));
                         pClone.ParameterName = newName;
                         Params.Add(pClone);
                     }
@@ -1755,6 +1756,12 @@ protected string ConvertInExpressionToSql(MethodCallExpression m, object quotedC
                         Params.Add(p);
                     }
                 }
+
+                for (var i = renameParams.Count - 1; i >= 0; i--)
+                {
+                    subSelect = subSelect.Replace(renameParams[i].Item1, renameParams[i].Item2);
+                }
+
                 return string.Format("{0} {1} ({2})", quotedColName, "IN", subSelect);
             }
 

tests/ServiceStack.OrmLite.Tests/Issues/MergingNestedSqlExpressionIssue.cs

@@ -0,0 +1,46 @@
+using System;
+using NUnit.Framework;
+using ServiceStack.OrmLite.Sqlite;
+
+namespace ServiceStack.OrmLite.Tests.Issues
+{
+    public class Organization
+    {
+        public Guid Id { get; set; }
+        public bool IsActive { get; set; }
+        public string Name { get; set; }
+    }
+
+    public class OrganizationMembership
+    {
+        public Guid Id { get; set; }
+        public Guid OrganizationId { get; set; }
+        public bool HasA { get; set; }
+        public bool HasB { get; set; }
+        public bool HasC { get; set; }
+    }
+
+    public class MergingNestedSqlExpressionIssue : OrmLiteTestBase
+    {
+        [Test]
+        public void Does_merge_subselect_params_correctly()
+        {
+            OrmLiteConfig.DialectProvider = new SqliteOrmLiteDialectProvider();
+
+            // select a group of ids
+            var ids = OrmLiteConfig.DialectProvider.SqlExpression<OrganizationMembership>();
+            ids.Where(x => x.HasA == true && x.HasB == true && x.HasC == true);
+            ids.SelectDistinct(x => x.OrganizationId);
+
+            // select organizations
+            var expression = OrmLiteConfig.DialectProvider.SqlExpression<Organization>();
+            // that are active
+            expression.Where(x => x.IsActive == true);
+            // and belong to the same group
+            expression.Where(x => Sql.In(x.Id, ids));
+
+            Assert.That(expression.WhereExpression, Is.EqualTo(
+                "WHERE (\"IsActive\" = @0) AND \"Id\" IN (SELECT DISTINCT \"OrganizationId\" \nFROM \"OrganizationMembership\"\nWHERE (((\"HasA\" = @1) AND (\"HasB\" = @2)) AND (\"HasC\" = @3)))"));
+        }
+    }
+}

tests/ServiceStack.OrmLite.Tests/ServiceStack.OrmLite.Tests.csproj

@@ -130,6 +130,7 @@
     <Compile Include="DateTimeTests.cs" />
     <Compile Include="DefaultValueTests.cs" />
     <Compile Include="Issues\BelongsToIssue.cs" />
+    <Compile Include="Issues\MergingNestedSqlExpressionIssue.cs" />
     <Compile Include="UseCase\ExpressionsAuthorTests.cs" />
     <Compile Include="Expression\ComplexJoinTests.cs" />
     <Compile Include="Expression\ExpressionUsingCustomSerializedEnumTests.cs" />