Return status for inc_backup() is IGNORED !?

[WernerMairl]

Hi
you are ignoring the result (0/1) for inc_backup(), the entire autoxtrbackup run results in a false positive exitcode!
That may not be the best practice :-(

MySQL-AutoXtraBackup/master_backup_script/backuper.py

Line 753 in 72ca0a8

self.inc_backup()

MySQL-AutoXtraBackup/master_backup_script/backuper.py

Line 760 in 72ca0a8

return True

impact: i got some error in the next run of autoxtrabackup during preparation.... but it was really hard to find out that the root cause was in the backup before with a false positive exit :-(

regards
Werner

[ShahriyarR]

:( sorry for the bad experience, in fact, most of the code base has been refactored for release_v2.0.
#389

I have implemented docker container runs, API calls, etc.
Basically, we need to release this major release with a bunch of improvements - but at the time being, I am doing so much different things that, could not wrap up with this release.
Could you please suggest a fix for this issue? - I can add this fix also to the 2.0 release. Thanks)

[WernerMairl]

Could you please suggest a fix for this issue?

Not as a py code because i have never used py as a developer....

What i suggest:
The caller of backup_inc() should check the return code and if not 0 then maybe a runtime error can be thrown
(fail fast and early).

That may have impact to some workflow, but better a runtime exception then a false positive result.

regards
Werner

[ShahriyarR]

Indeed, proper error handling related to exit codes should be applied here as well.
Thanks for the report - converting to the bug as verified.

[WernerMairl]

found another "worst case" scenario (same bug pattern) for full backup:

the follwoing line is not respecting the result from line 703!

MySQL-AutoXtraBackup/master_backup_script/backuper.py

Line 712 in 72ca0a8

return True

basically i was able to do a full backup and a incremental backup both with false positive end status :-(

[ShahriyarR]

@WernerMairl As I have released version 2.0, this error should not be encountered anymore.
Could you please checkout out the latest version of our tool?
Thanks :)