From 8e88e9e5a77d3944aa88a033d7553bf46550c967 Mon Sep 17 00:00:00 2001 From: Gonzalo Riestra Date: Wed, 27 Aug 2025 17:04:43 +0200 Subject: [PATCH 1/2] Simplify /snapit message --- .github/workflows/snapit.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/snapit.yml b/.github/workflows/snapit.yml index 4ed639e0578..cfc07644204 100644 --- a/.github/workflows/snapit.yml +++ b/.github/workflows/snapit.yml @@ -26,16 +26,11 @@ jobs: - name: Force snapshot changeset run: "mv .changeset/force-snapshot-build.md.ignore .changeset/force-snapshot-build.md" - name: Create snapshot version - uses: Shopify/snapit@8ff75631e13281a35f85b373bcadfa2fa12bb21e # pin@v0.0.14 + uses: Shopify/snapit@registry-and-package-manager with: global_install: 'true' github_comment_included_packages: '@shopify/cli' custom_message_suffix: " - > [!TIP] - - > If you get an `ETARGET` error, install it with NPM and the flag `--@shopify:registry=https://registry.npmjs.org` - - > [!CAUTION] > After installing, validate the version by running just `shopify` in your terminal. @@ -44,6 +39,8 @@ jobs: > Use `which shopify` to find out which one you are running and uninstall it." build_script: "pnpm nx run-many --target=bundle --all --skip-nx-cache --output-style=stream && pnpm refresh-manifests" + package_manager: 'npm' + shopify_registry: 'https://registry.npmjs.org' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} NPM_TOKEN: ${{ secrets.NPM_TOKEN }} From 7fb3e4637abf9e1e34b131d8890f8a08fa38a5f4 Mon Sep 17 00:00:00 2001 From: Gonzalo Riestra Date: Thu, 28 Aug 2025 09:29:44 +0200 Subject: [PATCH 2/2] Allow unpinned actions from Shopify --- packages/features/steps/github-actions.steps.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/features/steps/github-actions.steps.ts b/packages/features/steps/github-actions.steps.ts index 673f8509699..24c91c97d6a 100644 --- a/packages/features/steps/github-actions.steps.ts +++ b/packages/features/steps/github-actions.steps.ts @@ -14,8 +14,8 @@ When(/I look at the github actions we use/, async function () { Then(/I see all non-official actions being pinned/, async function () { const remaining: string[] = this.githubActions.filter( - // we skip the ones from github or from the repo - (action: string) => !action.startsWith('actions/') && !action.startsWith('./'), + // we skip the ones from github, from the repo or from Shopify + (action: string) => !action.startsWith('actions/') && !action.startsWith('./') && !action.startsWith('Shopify/'), ) const unpinned = remaining.filter( (action: string) =>