From d4fee6807b18ca5c23c5ada91532f483f8c16eee Mon Sep 17 00:00:00 2001 From: Espen Hovland Date: Fri, 3 Jul 2026 09:27:13 +0200 Subject: [PATCH 1/4] Update contributions guidelines --- .github/CONTRIBUTING.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 8b37ee2..ac141ad 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -113,7 +113,7 @@ Another line of really good description ``` ## Pull Request Guideline -Okay you finished your work committed all your changes to your branch. Time to create a pull request. +Okay, you finished your work and committed all your changes to your branch. Time to create a pull request. Refer to the general pull request [guideline](https://opensource.guide/how-to-contribute/#opening-a-pull-request) from GitHub. What to consider when raising a Pull Request: 1. **Pull Request Naming** @@ -124,10 +124,8 @@ What to consider when raising a Pull Request: GitHub assigns reviewers based on the [CODEOWNERS](CODEOWNERS) file. Add more reviewers if needed. Do not remove reviewers from the PR. Ask the repository owner for updates to the code owners. 4. **Evaluate the Action Workflow Results** - The following workflows are included in every repository: - - **[Coding Convention Check](workflows/00-Check-Code-Convention.yml)**: Analyzes the code formatting and fails if any rules are broken. - - **[Firmware Build](workflows/02-Build-Firmware.yml)**: Builds the firmware inside the [Dockerfile](../Dockerfile). - - **[Secret Scanner](workflows/04-TruffleHog-Security-Scan.yml)**: Runs the TruffleHog security scanner to look for API keys and committed secrets. + The following workflows are included in this repository: + - **[Unit tests and Coverage Report](workflows/unittest-and-coverage.yml)**: Runs the unit tests and generates the coverage report. Total coverage should remain in the high 90s. ### As a Reviewer From 4f321d780354c2a66ba59c0f75e410a71fdc3f28 Mon Sep 17 00:00:00 2001 From: Espen Hovland Date: Fri, 3 Jul 2026 09:28:56 +0200 Subject: [PATCH 2/4] Auto-run unittests and coverage on certain branches Now that we're going public, there are less restrictions on runner usage and storage. Run some more tests on each commit for certain branches. --- .github/workflows/unittest-and-coverage.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/unittest-and-coverage.yml b/.github/workflows/unittest-and-coverage.yml index 2a215df..4707a4a 100644 --- a/.github/workflows/unittest-and-coverage.yml +++ b/.github/workflows/unittest-and-coverage.yml @@ -1,6 +1,10 @@ name: Unit tests and Coverage Report on: + push: + branches: + - main + - develop/** workflow_dispatch: permissions: From ca44bf631d13b20372ccf67f220849a9823e3300 Mon Sep 17 00:00:00 2001 From: Espen Hovland Date: Fri, 3 Jul 2026 10:50:19 +0200 Subject: [PATCH 3/4] Also run unittests on PRs Aligns more nicely with the stuff in the contribution guidelines --- .github/workflows/unittest-and-coverage.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/unittest-and-coverage.yml b/.github/workflows/unittest-and-coverage.yml index 4707a4a..ed0be60 100644 --- a/.github/workflows/unittest-and-coverage.yml +++ b/.github/workflows/unittest-and-coverage.yml @@ -5,6 +5,10 @@ on: branches: - main - develop/** + pull_request: + branches: + - main + - develop/** workflow_dispatch: permissions: From cd59b43b540ab3af07b35bf92492b693503642ca Mon Sep 17 00:00:00 2001 From: Espen Hovland Date: Fri, 3 Jul 2026 14:27:58 +0200 Subject: [PATCH 4/4] Remove rulesets These settings are provided via the Terraform backend, and not in the repo itself --- .../rulesets/Silabs-basic-public-ruleset.json | 60 ------------------- .../Silabs-basic-ruleset-internal.json | 55 ----------------- 2 files changed, 115 deletions(-) delete mode 100644 .github/rulesets/Silabs-basic-public-ruleset.json delete mode 100644 .github/rulesets/Silabs-basic-ruleset-internal.json diff --git a/.github/rulesets/Silabs-basic-public-ruleset.json b/.github/rulesets/Silabs-basic-public-ruleset.json deleted file mode 100644 index 3fb4e6b..0000000 --- a/.github/rulesets/Silabs-basic-public-ruleset.json +++ /dev/null @@ -1,60 +0,0 @@ -{ - "id": 2684086, - "name": "Main and release branches are protected", - "target": "branch", - "source_type": "Repository", - "source": "SiliconLabsSoftware/devs-template-public", - "enforcement": "active", - "conditions": { - "ref_name": { - "exclude": [], - "include": [ - "refs/heads/release/**/*", - "refs/heads/master", - "refs/heads/main" - ] - } - }, - "rules": [ - { - "type": "deletion" - }, - { - "type": "non_fast_forward" - }, - { - "type": "pull_request", - "parameters": { - "required_approving_review_count": 1, - "dismiss_stale_reviews_on_push": true, - "require_code_owner_review": true, - "require_last_push_approval": true, - "required_review_thread_resolution": true, - "automatic_copilot_code_review_enabled": true, - "allowed_merge_methods": [ - "merge", - "squash", - "rebase" - ] - } - }, - { - "type": "creation" - }, - { - "type": "required_signatures" - } - ], - "bypass_actors": [ - { - "actor_id": null, - "actor_type": "OrganizationAdmin", - "bypass_mode": "always" - }, - { - "actor_id": 5, - "actor_type": "RepositoryRole", - "bypass_mode": "always" - } - ] -} \ No newline at end of file diff --git a/.github/rulesets/Silabs-basic-ruleset-internal.json b/.github/rulesets/Silabs-basic-ruleset-internal.json deleted file mode 100644 index f7ca134..0000000 --- a/.github/rulesets/Silabs-basic-ruleset-internal.json +++ /dev/null @@ -1,55 +0,0 @@ -{ - "id": 4076935, - "name": "Main and release branches are protected", - "target": "branch", - "source_type": "Repository", - "source": "SiliconLabsSoftware/devs-template", - "enforcement": "active", - "conditions": { - "ref_name": { - "exclude": [], - "include": [ - "~DEFAULT_BRANCH", - "refs/heads/main", - "refs/heads/master", - "refs/heads/release/**" - ] - } - }, - "rules": [ - { - "type": "deletion" - }, - { - "type": "non_fast_forward" - }, - { - "type": "pull_request", - "parameters": { - "required_approving_review_count": 1, - "dismiss_stale_reviews_on_push": true, - "require_code_owner_review": true, - "require_last_push_approval": true, - "required_review_thread_resolution": true, - "automatic_copilot_code_review_enabled": true, - "allowed_merge_methods": [ - "merge", - "squash", - "rebase" - ] - } - } - ], - "bypass_actors": [ - { - "actor_id": null, - "actor_type": "OrganizationAdmin", - "bypass_mode": "always" - }, - { - "actor_id": 5, - "actor_type": "RepositoryRole", - "bypass_mode": "always" - } - ] -} \ No newline at end of file