OneJS V3: Solve 'Object.GetInstanceID()' is obsolete

[Waxime64]

Hi a begin to developp a new projet with OneJS V3 + last version of unity. It's possible to solve last depreciate command for full compatibility ?

Library\PackageCache\com.singtaa.onejs@403acce\Editor\OneJSEditorOverlay.cs(152,26): error CS0619: 'Object.GetInstanceID()' is obsolete: 'GetInstanceID is deprecated. Use GetEntityId instead. This will be removed in a future version.'

original code
// Screen-space panels are always visible regardless of camera
var ps = runner.PanelSettingsAsset;
if (ps != null && RenderModeField != null) {
var id = ps.GetInstanceID();
if (!_screenSpacePanelCache.TryGetValue(id, out var isScreenSpace)) {
isScreenSpace = (int)RenderModeField.GetValue(ps) == 0;
_screenSpacePanelCache[id] = isScreenSpace;
}
if (isScreenSpace) return true;
}

correction
var id = ps.GetEntityId();

and update your Dictionary
static readonly Dictionary<EntityId, bool> _screenSpacePanelCache = new();

After this change, OneJS is compatible with Unity 6.6 Alpha

[Singtaa]

Thx! I just wrapped both the dictionary declaration (line 32) and the call site (line 156) in #if UNITY_6000_6_OR_NEWER so Unity 6.6+ uses GetEntityId() / Dictionary<EntityId, bool>, while Unity 6.0–6.5 keeps the existing GetInstanceID() / Dictionary<int, bool> path.

Think that should be enough, right?

[Waxime64]

Update git

and Yes work without Hack

[Singtaa]

Great!