Merge pull request #142 from Snow-Shell/fix-141

add UseBasicParsing

Author: gdbarron

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 2.4.2
+- Fix [#141](https://github.com/Snow-Shell/servicenow-powershell/issues/141), add `UseBasicParsing` to all API calls to keep AA from failing when IE hasn't been initialized
+
 ## 2.4.1
 - Add `-IncludeCustomVariable` to `Get-ServiceNowRecord` to retrieve custom variables, eg. ritm form values, in addition to the standard fields.  [#138](https://github.com/Snow-Shell/servicenow-powershell/discussions/138)
 

ServiceNow/Private/Invoke-ServiceNowRestMethod.ps1

@@ -84,6 +84,7 @@ function Invoke-ServiceNowRestMethod {
 
     $params.Method = $Method
     $params.ContentType = 'application/json'
+    $params.UseBasicParsing = $true
 
     if ( $Table ) {
         # table can either be the actual table name or class name

ServiceNow/Public/Add-ServiceNowAttachment.ps1

@@ -130,6 +130,7 @@ Function Add-ServiceNowAttachment {
             $invokeRestMethodSplat = $auth
             $invokeRestMethodSplat.Uri += '/attachment/file?table_name={0}&table_sys_id={1}&file_name={2}' -f $Table, $sysId, $FileData.Name
             $invokeRestMethodSplat.Headers += @{'Content-Type' = $ContentType }
+            $invokeRestMethodSplat.UseBasicParsing = $true
             $invokeRestMethodSplat += @{
                 Method = 'POST'
                 InFile = $FileData.FullName

ServiceNow/Public/Get-ServiceNowAttachment.ps1

@@ -107,6 +107,7 @@ Function Get-ServiceNowAttachment {
 
         # URI format:  https://tenant.service-now.com/api/now/attachment/{sys_id}/file
         $params.Uri += '/attachment/' + $SysID + '/file'
+        $params.UseBasicParsing = $true
 
         If ($AppendNameWithSysID.IsPresent) {
             $FileName = "{0}_{1}{2}" -f [io.path]::GetFileNameWithoutExtension($FileName),

ServiceNow/Public/New-ServiceNowSession.ps1

@@ -108,7 +108,8 @@ function New-ServiceNowSession {
 
     if ( $ApiVersion -le 0 ) {
         $version = ''
-    } else {
+    }
+    else {
         $version = ('/v{0}' -f $ApiVersion)
     }
 
@@ -127,23 +128,25 @@ function New-ServiceNowSession {
     switch -Wildcard ($PSCmdLet.ParameterSetName) {
         'OAuth*' {
             $params = @{
-                Uri    = 'https://{0}/oauth_token.do' -f $Url
-                Body   = @{
+                Uri             = 'https://{0}/oauth_token.do' -f $Url
+                Body            = @{
                     'grant_type'    = 'password'
                     'client_id'     = $ClientCredential.UserName
                     'client_secret' = $ClientCredential.GetNetworkCredential().Password
                     'username'      = $Credential.UserName
                     'password'      = $Credential.GetNetworkCredential().Password
                 }
-                Method = 'Post'
+                Method          = 'Post'
+                UseBasicParsing = $true
             }
 
             # need to add this manually here, in addition to above, since we're making a rest call before our session is created
             if ( $PSBoundParameters.ContainsKey('Proxy') ) {
                 $params.Add('Proxy', $Proxy)
                 if ( $PSBoundParameters.ContainsKey('ProxyCredential') ) {
                     $params.Add('ProxyCredential', $ProxyCredential)
-                } else {
+                }
+                else {
                     $params.Add('ProxyUseDefaultCredentials', $true)
                 }
             }
@@ -196,7 +199,8 @@ function New-ServiceNowSession {
 
     if ( $PassThru ) {
         $newSession
-    } else {
+    }
+    else {
         $Script:ServiceNowSession = $newSession
     }
 }

ServiceNow/ServiceNow.psd1

@@ -5,7 +5,7 @@
 RootModule = 'ServiceNow.psm1'
 
 # Version number of this module.
-ModuleVersion = '2.4.1'
+ModuleVersion = '2.4.2'
 
 # ID used to uniquely identify this module
 GUID = 'b90d67da-f8d0-4406-ad74-89d169cd0633'