Bug fix in Update-ServiceNowNumber. Added Pester Test.

Author: Rick-2CA

ServiceNow/Public/Update-ServiceNowNumber.ps1

@@ -70,15 +70,15 @@ Function Update-ServiceNowNumber {
             # Process credential steps based on parameter set name
             Switch ($PSCmdlet.ParameterSetName) {
                 'SpecifyConnectionFields' {
+                    $getServiceNowTableEntry.Add('ServiceNowCredential',$Credential)
+                    $getServiceNowTableEntry.Add('ServiceNowURL',$ServiceNowURL)
                     $ServiceNowURL = 'https://' + $ServiceNowURL + '/api/now/v1'
-                    $updateServiceNowTableEntrySplat.Add('ServiceNowCredential',$ServiceNowCredential)
-                    $updateServiceNowTableEntrySplat.Add('ServiceNowURL',$ServiceNowURL)
                 }
                 'UseConnectionObject' {
+                    $getServiceNowTableEntry.Add('Connection',$Connection)
                     $SecurePassword = ConvertTo-SecureString $Connection.Password -AsPlainText -Force
                     $Credential = New-Object System.Management.Automation.PSCredential ($Connection.Username, $SecurePassword)
                     $ServiceNowURL = 'https://' + $Connection.ServiceNowUri + '/api/now/v1'
-                    $updateServiceNowTableEntrySplat.Add('Connection',$Connection)
                 }
                 Default {
                     If ((Test-ServiceNowAuthIsSet)) {
@@ -90,9 +90,10 @@ Function Update-ServiceNowNumber {
                     }
                 }
             }
-
+            Write-Verbose "ServiceNowURL:  $ServiceNowURL"
             # Use the number and table to determine the sys_id
             $SysID = Get-ServiceNowTableEntry @getServiceNowTableEntry | Select-Object -Expand sys_id
+            Write-Verbose "SysID:  $SysID"
 
             # Convert the values to Json and encode them to an UTF8 array to support special chars
             $Body = $Values | ConvertTo-Json

Tests/ServiceNow.Tests.ps1

@@ -202,6 +202,41 @@ Describe "ServiceNow-Module" {
         $TestTicket.description | Should -Be 'Updated by Pester test Update-ServiceNowNumber works'
     }
 
+    It "Update-ServiceNowNumber with SpecifyConnectionFields works" {
+        $ShortDescription = 'Testing Ticket Update with Pester'
+        $newServiceNowIncidentSplat = @{
+            Caller              = $Defaults.TestUser
+            ShortDescription    = $ShortDescription
+            Description         = 'Long description'
+            AssignmentGroup     = $Defaults.TestUserGroup
+            Comment             = 'Comment'
+            Category            = $Defaults.TestCategory
+            SubCategory         = $Defaults.TestSubcategory
+            ConfigurationItem   = $Defaults.TestConfigurationItem
+        }
+        $TestTicket = New-ServiceNowIncident @newServiceNowIncidentSplat
+
+        $TestTicket.short_description | Should -Be $ShortDescription
+
+        $Values = @{
+            'short_description' = 'Ticket Updated with Pester (Update-ServiceNowNumber)'
+            'description'       = 'Updated by Pester test Update-ServiceNowNumber with SpecifyConnectionFields works'
+        }
+
+        $updateServiceNowNumberSplat = @{
+            Number        = $TestTicket.Number
+            Table         = 'incident'
+            Values        = $Values
+            Credential    = $Defaults.Creds
+            ServiceNowURL = $Defaults.ServiceNowURL
+        }
+        Update-ServiceNowNumber @updateServiceNowNumberSplat
+
+        $TestTicket = Get-ServiceNowIncident -MatchExact @{sys_id=$TestTicket.sys_id}
+        $TestTicket.short_description | Should -Be 'Ticket Updated with Pester (Update-ServiceNowNumber)'
+        $TestTicket.description | Should -Be 'Updated by Pester test Update-ServiceNowNumber with SpecifyConnectionFields works'
+    }
+
     # Remove Functions
     It "Remove-ServiceNowTable works" {
         $TestTicket = Get-ServiceNowIncident -Limit 1