Quality changes

Fixed position of -Fields parameter by request.

Correctly hooked up the -Fields parameter in several functions.

Author: replicaJunction

ServiceNow/Public/Get-ServiceNowChangeRequest.ps1

@@ -2,10 +2,6 @@ function Get-ServiceNowChangeRequest {
     [OutputType([System.Management.Automation.PSCustomObject])]
     [CmdletBinding(DefaultParameterSetName)]
     Param(
-        # Fields to return
-        [parameter(mandatory = $false)]
-        [string[]]$Fields,
-
         # Machine name of the field to order by
         [Parameter(Mandatory = $false)]
         [string]$OrderBy = 'opened_at',
@@ -19,6 +15,10 @@ function Get-ServiceNowChangeRequest {
         [Parameter(Mandatory = $false)]
         [int]$Limit = 10,
 
+        # Fields to return
+        [parameter(mandatory = $false)]
+        [string[]]$Fields,
+
         # Hashtable containing machine field names and values returned must match exactly (will be combined with AND)
         [Parameter(Mandatory = $false)]
         [hashtable]$MatchExact = @{},
@@ -60,7 +60,8 @@ function Get-ServiceNowChangeRequest {
     $getServiceNowTableSplat = @{
         Table           = 'change_request'
         Query           = $Query
-        Limit           = $Limit
+        Limit           = $
+        Fields          = $Fields
         DisplayValues   = $DisplayValues
     }
 

ServiceNow/Public/Get-ServiceNowConfigurationItem.ps1

@@ -2,10 +2,6 @@ function Get-ServiceNowConfigurationItem {
     [OutputType([System.Management.Automation.PSCustomObject])]
     [CmdletBinding(DefaultParameterSetName)]
     Param(
-        # Fields to return
-        [parameter(mandatory = $false)]
-        [string[]]$Fields,
-
         # Machine name of the field to order by
         [Parameter(Mandatory = $false)]
         [string]$OrderBy = 'name',
@@ -19,6 +15,10 @@ function Get-ServiceNowConfigurationItem {
         [Parameter(Mandatory = $false)]
         [int]$Limit = 10,
 
+        # Fields to return
+        [parameter(mandatory = $false)]
+        [string[]]$Fields,
+
         # Hashtable containing machine field names and values returned must match exactly (will be combined with AND)
         [Parameter(Mandatory = $false)]
         [hashtable]$MatchExact = @{},
@@ -61,6 +61,7 @@ function Get-ServiceNowConfigurationItem {
         Table           = 'cmdb_ci'
         Query           = $Query
         Limit           = $Limit
+        Fields          = $Fields
         DisplayValues   = $DisplayValues
     }
 

ServiceNow/Public/Get-ServiceNowIncident.ps1

@@ -2,10 +2,6 @@ function Get-ServiceNowIncident{
     [OutputType([System.Management.Automation.PSCustomObject])]
     [CmdletBinding(DefaultParameterSetName)]
     Param(
-        # Fields to return
-        [parameter(mandatory = $false)]
-        [string[]]$Fields,
-
         # Machine name of the field to order by
         [Parameter(Mandatory = $false)]
         [string]$OrderBy = 'opened_at',
@@ -19,6 +15,10 @@ function Get-ServiceNowIncident{
         [Parameter(Mandatory = $false)]
         [int]$Limit = 10,
 
+        # Fields to return
+        [parameter(mandatory = $false)]
+        [string[]]$Fields,
+
         # Hashtable containing machine field names and values returned must match exactly (will be combined with AND)
         [Parameter(Mandatory = $false)]
         [hashtable]$MatchExact = @{},
@@ -61,6 +61,7 @@ function Get-ServiceNowIncident{
         Table = 'incident'
         Query = $Query
         Limit = $Limit
+        Fields        = $Fields
         DisplayValues = $DisplayValues
     }
 

ServiceNow/Public/Get-ServiceNowRequest.ps1

@@ -2,10 +2,6 @@ function Get-ServiceNowRequest {
     [OutputType([System.Management.Automation.PSCustomObject])]
     [CmdletBinding(DefaultParameterSetName)]
     Param(
-        # Fields to return
-        [parameter(mandatory = $false)]
-        [string[]]$Fields,
-
         # Machine name of the field to order by
         [Parameter(Mandatory = $false)]
         [string]$OrderBy = 'opened_at',
@@ -19,6 +15,10 @@ function Get-ServiceNowRequest {
         [Parameter(Mandatory = $false)]
         [int]$Limit = 10,
 
+        # Fields to return
+        [parameter(mandatory = $false)]
+        [string[]]$Fields,
+
         # Hashtable containing machine field names and values returned must match exactly (will be combined with AND)
         [Parameter(Mandatory = $false)]
         [hashtable]$MatchExact = @{},
@@ -61,6 +61,7 @@ function Get-ServiceNowRequest {
         Table         = 'sc_request'
         Query         = $Query
         Limit         = $Limit
+        Fields        = $Fields
         DisplayValues = $DisplayValues
     }
 

ServiceNow/Public/Get-ServiceNowRequestItem.ps1

@@ -18,10 +18,6 @@ function Get-ServiceNowRequestItem {
     [OutputType([System.Management.Automation.PSCustomObject])]
     [CmdletBinding(DefaultParameterSetName)]
     param(
-        # Fields to return
-        [parameter(mandatory = $false)]
-        [string[]]$Fields,
-
         # Machine name of the field to order by
         [parameter(Mandatory = $false)]
         [string]$OrderBy = 'opened_at',
@@ -35,6 +31,10 @@ function Get-ServiceNowRequestItem {
         [parameter(Mandatory = $false)]
         [int]$Limit = 10,
 
+        # Fields to return
+        [parameter(mandatory = $false)]
+        [string[]]$Fields,
+
         # Hashtable containing machine field names and values returned must match exactly (will be combined with AND)
         [parameter(Mandatory = $false)]
         [hashtable]$MatchExact = @{},