fix paging, prop name updates

Author: gdbarron

ServiceNow/Private/Invoke-ServiceNowRestMethod.ps1

@@ -52,13 +52,14 @@ function Invoke-ServiceNowRestMethod {
 
         # Fields to return
         [Parameter()]
-        [Alias('Fields')]
-        [string[]] $Properties,
+        [Alias('Fields', 'Properties')]
+        [string[]] $Property,
 
         # Whether or not to show human readable display values instead of machine values
         [Parameter()]
         [ValidateSet('true', 'false', 'all')]
-        [string] $DisplayValues = 'true',
+        [Alias('DisplayValues')]
+        [string] $DisplayValue = 'true',
 
         [Parameter()]
         [PSCredential] $Credential,
@@ -104,7 +105,7 @@ function Invoke-ServiceNowRestMethod {
 
     if ( $Method -eq 'Get') {
         $Body = @{
-            'sysparm_display_value' = $DisplayValues
+            'sysparm_display_value' = $DisplayValue
             'sysparm_query'         = (New-ServiceNowQuery -Filter $Filter -Sort $Sort)
             'sysparm_limit'         = 10
         }
@@ -128,8 +129,8 @@ function Invoke-ServiceNowRestMethod {
             $Body.sysparm_query = $Query
         }
 
-        if ($Properties) {
-            $Body.sysparm_fields = ($Properties -join ',').ToLower()
+        if ($Property) {
+            $Body.sysparm_fields = ($Property -join ',').ToLower()
         }
     }
 

ServiceNow/Public/Get-ServiceNowRecord.ps1

@@ -122,23 +122,26 @@ function Get-ServiceNowRecord {
         [hashtable] $ServiceNowSession = $script:ServiceNowSession
     )
 
-    $invokeParams = @{
-        Table             = $Table
-        Properties        = $Property
-        Filter            = $Filter
-        Sort              = $Sort
-        DisplayValues     = $DisplayValue
-        Connection        = $Connection
-        ServiceNowSession = $ServiceNowSession
-    }
+    # $invokeParams = @{
+    #     Table             = $Table
+    #     Properties        = $Property
+    #     Filter            = $Filter
+    #     Sort              = $Sort
+    #     DisplayValues     = $DisplayValue
+    #     Connection        = $Connection
+    #     ServiceNowSession = $ServiceNowSession
+    # }
+
+    $invokeParams = $PSBoundParameters
+    $invokeParams.Remove('IncludeCustomVariable') | Out-Null
 
     $addedSysIdProp = $false
 
     # we need the sys_id value in order to get custom var data
     # add it in if specific properties were requested and not part of the list
     if ( $IncludeCustomVariable.IsPresent ) {
         if ( $Property -and 'sys_id' -notin $Property ) {
-            $invokeParams.Properties += 'sys_id'
+            $invokeParams.Property += 'sys_id'
             $addedSysIdProp = $true
         }
     }