table name fix

Author: gdbarron

ServiceNow/Public/Get-ServiceNowRecord.ps1

@@ -68,7 +68,7 @@
 .EXAMPLE
     Get-ServiceNowRecord -Table 'Catalog Task' -ParentId 'RITM0010001'
     Get tasks for the parent requested item
-    
+
 .EXAMPLE
     Get-ServiceNowRecord -Table incident -Filter @('state', '-eq', '1') -Description 'powershell'
     Get incident records where state equals New or short description contains the word powershell
@@ -106,7 +106,7 @@
 .EXAMPLE
     gsnr RITM0010001
     Get a specific record by number using the function alias
-    
+
 .INPUTS
     None
 
@@ -205,13 +205,13 @@ function Get-ServiceNowRecord {
             }
         }
     }
-    
+
     if ( $Id ) {
         if ( $Id -match '^[a-zA-Z0-9]{32}$' ) {
             if ( -not $thisTable ) {
                 throw 'Providing sys_id for -Id requires a value for -Table.  Alternatively, provide an Id with a prefix, eg. INC1234567, and the table will be automatically determined.'
             }
-    
+
             $idFilter = @('sys_id', '-eq', $Id)
         }
         else {
@@ -226,19 +226,19 @@ function Get-ServiceNowRecord {
             }
             $idFilter = @('number', '-eq', $Id)
         }
-    
+
         if ( $invokeParams.Filter ) {
             $invokeParams.Filter = $invokeParams.Filter, 'and', $idFilter
         }
         else {
             $invokeParams.Filter = $idFilter
         }
-    
+
     }
-    
+
     # we have the table, update the params
     $invokeParams.Table = $thisTable.Name
-        
+
     if ( $ParentId ) {
         if ( $ParentId -match '^[a-zA-Z0-9]{32}$' ) {
             $parentIdFilter = @('parent.sys_id', '-eq', $ParentId)
@@ -254,11 +254,11 @@ function Get-ServiceNowRecord {
             $invokeParams.Filter = $parentIdFilter
         }
     }
-    
+
     if ( $Description ) {
         # determine the field we should compare for 'description' and add the filter
         if ( -not $thisTable.DescriptionField ) {
-            Write-Warning ('We do not have table ''{0}'' in the config; short_description will be used as the description field' -f $Table)
+            Write-Warning ('We do not have table ''{0}'' in the config; short_description will be used as the description field' -f $thisTable.Name)
             $thisTable.DescriptionField = 'short_description'
         }
 
@@ -281,11 +281,12 @@ function Get-ServiceNowRecord {
     }
 
     # should use Get-ServiceNowAttachment, but put this here for ease of access
-    if ( $Table -eq 'attachment' ) {
+    if ( $thisTable.Name -eq 'attachment' ) {
+        Write-Warning 'For attachments, use Get-ServiceNowAttachment'
         $invokeParams.Remove('Table') | Out-Null
         $invokeParams.UriLeaf = '/attachment'
     }
-    
+
     $result = Invoke-ServiceNowRestMethod @invokeParams
 
     if ( $result ) {
@@ -302,7 +303,7 @@ function Get-ServiceNowRecord {
 
                 if ( $customVars ) {
                     $customValueParams = @{
-                        Table    = $Table
+                        Table    = $thisTable.Name
                         Filter   = @('sys_id', '-eq', $record.sys_id)
                         Property = $customVars.'sc_item_option.item_option_new.name' | ForEach-Object { "variables.$_" }
                     }

ServiceNow/Public/New-ServiceNowSession.ps1

@@ -153,7 +153,7 @@ function New-ServiceNowSession {
 
             $oldProgressPreference = $ProgressPreference
             $ProgressPreference = 'SilentlyContinue'
-        
+
             $response = Invoke-WebRequest @params
 
             # set the progress pref back now that done with invoke-webrequest
@@ -217,4 +217,26 @@ function New-ServiceNowSession {
     else {
         $Script:ServiceNowSession = $newSession
     }
+
+    Write-Verbose 'Getting table number prefixes'
+    $defaultTable = $ServiceNowTable
+    try {
+        $numbers = Get-ServiceNowRecord -Table 'sys_number' -Property prefix, category -First 10000
+        foreach ($number in $numbers) {
+            if ( $number.prefix.ToLower() -notin $defaultTable.NumberPrefix ) {
+                $ServiceNowTable.Add(
+                    [pscustomobject] @{
+                        "Name"             = ($number.category.link | Select-String -Pattern '^.*\?name=(.*)$').matches.groups[1].Value
+                        "ClassName"        = $number.category.display_value
+                        "Type"             = $null
+                        "NumberPrefix"     = $number.prefix.ToLower()
+                        "DescriptionField" = "short_description"
+                    }
+                ) | Out-Null
+            }
+        }
+    }
+    catch {
+        Write-Verbose "Session created, but failed to populate ServiceNowTable.  Prefixes beyond the default won't be available.  $_"
+    }
 }