fix(no-status-emoji): cascade rule self-disable + bypass scripts/tests

jdalton · jdalton · commit 35b4afe2bf69 · 2026-05-11T10:52:27.000-04:00
Bulk file-level `oxlint-disable socket/no-status-emoji` on scripts/*
and test/* files where emoji output is intentional (dev script status
prefixes, test assertions, TUI components). Drops no-status-emoji
findings to 0 in this repo.
diff --git a/.config/oxlint-plugin/rules/no-status-emoji.mts b/.config/oxlint-plugin/rules/no-status-emoji.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- this file IS the rule definition; emoji literals are lookup-table data, not real usage. */
+
 /**
  * @fileoverview Ban status-symbol emoji literals (✓ ✔ ❌ ✗ ⚠ ⚠️ ❗ ✅
  * ❎ ☑) inside string literals. The `@socketsecurity/lib/logger`
diff --git a/packages/build-infra/lib/build-pipeline.mts b/packages/build-infra/lib/build-pipeline.mts
@@ -290,6 +290,7 @@ async function runStage(stage, ctx, stageParams) {
   )
 
   if (!shouldProceed) {
+    // oxlint-disable-next-line socket/no-status-emoji -- substep takes its own indent prefix; ✓ marks the cache-hit state.
     logger.substep(`✓ ${stage.name} up-to-date (cached)`)
     return
   }
diff --git a/packages/build-infra/lib/checkpoint-manager.mts b/packages/build-infra/lib/checkpoint-manager.mts
@@ -179,6 +179,7 @@ export async function createCheckpoint(
   await fs.writeFile(file, `${JSON.stringify(data, null, 2)}\n`, 'utf8')
 
   const relRoot = packageRoot ? path.relative(packageRoot, file) : file
+  // oxlint-disable-next-line socket/no-status-emoji -- substep takes its own indent prefix; ✓ marks completion.
   logger.substep(`✓ Checkpoint ${name} written (${relRoot})`)
 }
 
diff --git a/packages/build-infra/lib/extraction-cache.mts b/packages/build-infra/lib/extraction-cache.mts
@@ -113,7 +113,7 @@ export async function shouldExtract({
 
     // Cache hit.
     const logger = getDefaultLogger()
-    logger.log(`✓ Using cached ${outputPath}`)
+    logger.success(`Using cached ${outputPath}`)
     return false
   } catch {
     // Any error, regenerate.
diff --git a/packages/cli/scripts/build-sea.mts b/packages/cli/scripts/build-sea.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * Build Socket SEA (Single Executable Application) binaries.
  * Uses pre-compiled Node.js smol binaries from socket-btm releases.
diff --git a/packages/cli/scripts/cover.mts b/packages/cli/scripts/cover.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Unified coverage script - runs tests with coverage reporting.
  * Standardized across all socket-* repositories.
diff --git a/packages/cli/scripts/e2e.mts b/packages/cli/scripts/e2e.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * E2E test runner.
  * Options: --js, --sea, --all
diff --git a/packages/cli/scripts/integration.mts b/packages/cli/scripts/integration.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * Integration test runner.
  * Options: --js, --sea, --all
diff --git a/packages/cli/scripts/sea-build-utils/downloads.mts b/packages/cli/scripts/sea-build-utils/downloads.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Download utilities for SEA build assets.
  * Manages downloads of node-smol binaries, binject tool, and security tools from GitHub releases.
diff --git a/packages/cli/scripts/setup-iocraft-dev.mts b/packages/cli/scripts/setup-iocraft-dev.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 #!/usr/bin/env node
 /**
  * @fileoverview Setup script to install iocraft dev build into node_modules for local testing.
diff --git a/packages/cli/scripts/test-asset-manager.mts b/packages/cli/scripts/test-asset-manager.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Test script for AssetManager in isolation.
  * Validates core functionality before Phase 2 migration.
diff --git a/packages/cli/scripts/test-entry.mts b/packages/cli/scripts/test-entry.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * Simple test entry point for SEA bundling test.
  * Just outputs version to verify the binary works.
diff --git a/packages/cli/scripts/utils/patches.mts b/packages/cli/scripts/utils/patches.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Utilities for creating pnpm patches using Babel AST + MagicString.
  * Provides helpers for transforming node_modules files and generating patch files.
diff --git a/packages/cli/scripts/wasm.mts b/packages/cli/scripts/wasm.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * Socket CLI WASM Bundle Manager
  *
diff --git a/packages/cli/src/commands/ask/output-ask.mts b/packages/cli/src/commands/ask/output-ask.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- TUI / custom output formatter; emojis are part of the visual contract. */
+
 import colors from 'yoctocolors-cjs'
 
 import { getDefaultLogger } from '@socketsecurity/lib/logger'
diff --git a/packages/cli/src/commands/fix/pr-lifecycle-logger.mts b/packages/cli/src/commands/fix/pr-lifecycle-logger.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- TUI / custom output formatter; emojis are part of the visual contract. */
+
 import colors from 'yoctocolors-cjs'
 
 import { getDefaultLogger } from '@socketsecurity/lib/logger'
diff --git a/packages/cli/src/utils/dlx/vfs-extract.mts b/packages/cli/src/utils/dlx/vfs-extract.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- TUI / custom output formatter; emojis are part of the visual contract. */
+
 /**
  * VFS extraction utilities for external tools bundled in SEA binaries.
  *
diff --git a/packages/cli/src/utils/output/scrubber.mts b/packages/cli/src/utils/output/scrubber.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- TUI / custom output formatter; emojis are part of the visual contract. */
+
 /**
  * Stdout scrubber for mixed child-process output under machine mode.
  *
diff --git a/packages/cli/src/utils/socket/api-error-messages.mts b/packages/cli/src/utils/socket/api-error-messages.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- user-facing API error strings; emojis are part of the message-template contract. */
+
 /**
  * User-facing error messages + permission-requirements logging for
  * Socket API failures.
diff --git a/packages/cli/src/utils/terminal/rich-progress.mts b/packages/cli/src/utils/terminal/rich-progress.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- TUI / custom output formatter; emojis are part of the visual contract. */
+
 /** @fileoverview Rich progress indicators for better CLI UX. */
 
 import colors from 'yoctocolors-cjs'
diff --git a/packages/cli/src/utils/terminal/simple-output.mts b/packages/cli/src/utils/terminal/simple-output.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- TUI / custom output formatter; emojis are part of the visual contract. */
+
 /** @fileoverview Simplified output formatter to DRY out repetitive output-*.mts files */
 
 import chalkTable from 'chalk-table'
diff --git a/packages/cli/test/integration/binary/helpers.mts b/packages/cli/test/integration/binary/helpers.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /** @fileoverview Shared helpers for binary integration tests. */
 
 import { existsSync } from 'node:fs'
diff --git a/packages/cli/test/unit/commands/fix/pr-lifecycle-logger.test.mts b/packages/cli/test/unit/commands/fix/pr-lifecycle-logger.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * Unit Tests: Pull Request Lifecycle Event Logger
  *
diff --git a/packages/cli/test/unit/commands/manifest/cmd-manifest-conda.test.mts b/packages/cli/test/unit/commands/manifest/cmd-manifest-conda.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * Unit tests for manifest conda command.
  *
diff --git a/packages/cli/test/unit/commands/wrapper/cmd-wrapper.test.mts b/packages/cli/test/unit/commands/wrapper/cmd-wrapper.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * Unit tests for wrapper command.
  *
diff --git a/packages/cli/test/unit/utils/alert/translations.test.mts b/packages/cli/test/unit/utils/alert/translations.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * Unit tests for alert translations.
  *
diff --git a/packages/cli/test/unit/utils/cli/with-subcommands-help.test.mts b/packages/cli/test/unit/utils/cli/with-subcommands-help.test.mts
@@ -193,6 +193,23 @@ describe('buildHelpLines', () => {
       expect(blob).not.toContain('mcp description')
     })
 
+    it('skips bucket entries whose subcommand is not registered (line 212)', () => {
+      // A bucket entry that has no matching subcommand should be silently
+      // skipped — defensive guard for stale buckets vs. removed commands.
+      const lines = buildHelpLines({
+        aliases: {},
+        argv: [],
+        buckets: { fix: 'main', 'ghost-command': 'main' } as any,
+        flags: FLAGS,
+        isRootCommand: true,
+        name: 'socket',
+        subcommands: { fix: makeSubcommand('fix description') } as any,
+      })
+      const blob = lines.join('\n')
+      expect(blob).toContain('fix')
+      expect(blob).not.toContain('ghost-command')
+    })
+
     it('emits hero rows in the Main commands bucket', () => {
       const lines = buildHelpLines({
         aliases: {},
diff --git a/packages/cli/test/unit/utils/dlx/spawn-synp.test.mts b/packages/cli/test/unit/utils/dlx/spawn-synp.test.mts
@@ -0,0 +1,70 @@
+/**
+ * Unit tests for the bespoke `spawnSynpDlx` flow.
+ *
+ * synp is a pure-npm package — no GitHub release, no local-binary override.
+ * `spawnSynpDlx` just delegates to `spawnDlx` with the pinned version.
+ * Vfs + auto-dispatch are exercised in define-tool-spawn.test.mts.
+ */
+
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const mockSpawnDlx = vi.hoisted(() => vi.fn())
+const mockGetSynpVersion = vi.hoisted(() => vi.fn(() => '1.9.0'))
+
+vi.mock('../../../../src/utils/dlx/spawn.mts', () => ({
+  spawnDlx: mockSpawnDlx,
+}))
+
+vi.mock('../../../../src/env/synp-version.mts', () => ({
+  getSynpVersion: mockGetSynpVersion,
+}))
+
+import { spawnSynpDlx } from '../../../../src/utils/dlx/spawn-synp.mts'
+
+describe('spawnSynpDlx', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    mockGetSynpVersion.mockReturnValue('1.9.0')
+  })
+
+  it('delegates to spawnDlx with the synp version pin', async () => {
+    mockSpawnDlx.mockResolvedValue({ spawnPromise: 'p' })
+
+    const result = await spawnSynpDlx(['--source-file', 'yarn.lock'])
+
+    expect(mockSpawnDlx).toHaveBeenCalledWith(
+      { name: 'synp', version: '1.9.0' },
+      ['--source-file', 'yarn.lock'],
+      { force: false },
+      undefined,
+    )
+    expect(result).toEqual({ spawnPromise: 'p' })
+  })
+
+  it('merges caller options over the default { force: false }', async () => {
+    mockSpawnDlx.mockResolvedValue({ spawnPromise: 'p' })
+
+    await spawnSynpDlx(['arg'], { force: true })
+
+    expect(mockSpawnDlx).toHaveBeenCalledWith(
+      { name: 'synp', version: '1.9.0' },
+      ['arg'],
+      { force: true },
+      undefined,
+    )
+  })
+
+  it('forwards spawnExtra to spawnDlx', async () => {
+    mockSpawnDlx.mockResolvedValue({ spawnPromise: 'p' })
+    const spawnExtra = { stdioString: true }
+
+    await spawnSynpDlx(['arg'], undefined, spawnExtra as any)
+
+    expect(mockSpawnDlx).toHaveBeenCalledWith(
+      { name: 'synp', version: '1.9.0' },
+      ['arg'],
+      { force: false },
+      spawnExtra,
+    )
+  })
+})
diff --git a/packages/cli/test/unit/utils/error/fail-msg-with-badge.test.mts b/packages/cli/test/unit/utils/error/fail-msg-with-badge.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * Unit tests for error message with badge.
  *
diff --git a/packages/cli/test/unit/utils/git/operations.test.mts b/packages/cli/test/unit/utils/git/operations.test.mts
@@ -783,4 +783,37 @@ describe('git utilities', () => {
       }
     })
   })
+
+  describe('getGitPath', () => {
+    it('throws a helpful error when whichReal returns null (line 58)', async () => {
+      // Reset modules so the module-level _gitPath cache is fresh and
+      // whichReal can be mocked to return null without other tests
+      // having already filled the cache.
+      vi.resetModules()
+      vi.doMock('@socketsecurity/lib/bin', () => ({
+        whichReal: vi.fn().mockResolvedValue(null),
+      }))
+      const { getGitPath: freshGetGitPath } = await import(
+        '../../../../src/utils/git/operations.mts'
+      )
+      await expect(freshGetGitPath()).rejects.toThrow(
+        /whichReal returned null/,
+      )
+      vi.doUnmock('@socketsecurity/lib/bin')
+      vi.resetModules()
+    })
+
+    it('throws when whichReal returns multiple matches', async () => {
+      vi.resetModules()
+      vi.doMock('@socketsecurity/lib/bin', () => ({
+        whichReal: vi.fn().mockResolvedValue(['/usr/bin/git', '/opt/bin/git']),
+      }))
+      const { getGitPath: freshGetGitPath } = await import(
+        '../../../../src/utils/git/operations.mts'
+      )
+      await expect(freshGetGitPath()).rejects.toThrow(/multiple matches/)
+      vi.doUnmock('@socketsecurity/lib/bin')
+      vi.resetModules()
+    })
+  })
 })
diff --git a/packages/cli/test/unit/utils/output/scrubber.test.mts b/packages/cli/test/unit/utils/output/scrubber.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 import { describe, expect, it } from 'vitest'
 import { Writable } from 'node:stream'
 
diff --git a/packages/cli/test/unit/utils/terminal/rich-progress.test.mts b/packages/cli/test/unit/utils/terminal/rich-progress.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * @fileoverview Tests for rich progress indicators and spinners.
  * Validates MultiProgress, Spinner, and FileProgress components.
diff --git a/packages/cli/test/unit/utils/validation/check-input.test.mts b/packages/cli/test/unit/utils/validation/check-input.test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test asserts on emoji output. */
+
 /**
  * Unit tests for input validation.
  *
diff --git a/packages/cli/test/utils.mts b/packages/cli/test/utils.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- test fixture: normalizes emoji output across Unicode/ASCII terminals. */
+
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 
diff --git a/packages/package-builder/scripts/generate-all.mts b/packages/package-builder/scripts/generate-all.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Generate all package directories from templates.
  * Runs all package generation scripts in sequence.
diff --git a/scripts/bootstrap-firewall-deps.mts b/scripts/bootstrap-firewall-deps.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Bootstrap zero-dep Socket packages into node_modules/
  * before `pnpm install` runs, with Socket Firewall verification on each
diff --git a/scripts/build.mts b/scripts/build.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * Comprehensive build script with intelligent caching.
  *
diff --git a/scripts/check-paths.mts b/scripts/check-paths.mts
@@ -90,6 +90,7 @@ const logger = {
   log: (msg: string) => process.stdout.write(msg + '\n'),
   error: (msg: string) => process.stderr.write(msg + '\n'),
   step: (msg: string) => process.stdout.write(`→ ${msg}\n`),
+  // oxlint-disable-next-line socket/no-status-emoji -- local logger replica; can't import lib's logger because this gate runs in socket-lib itself.
   success: (msg: string) => process.stdout.write(`✔ ${msg}\n`),
   substep: (msg: string) => process.stdout.write(`  ${msg}\n`),
 }
diff --git a/scripts/clean-cache.mts b/scripts/clean-cache.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * Clean stale caches across all packages.
  *
diff --git a/scripts/lib/build-exec.mts b/scripts/lib/build-exec.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Build execution utilities
  *
diff --git a/scripts/lib/build-output.mts b/scripts/lib/build-output.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Build output formatting utilities
  *
diff --git a/scripts/test.mts b/scripts/test.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Monorepo-aware test runner with smart file detection.
  * Runs tests across affected packages based on changed files.
diff --git a/scripts/type.mts b/scripts/type.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Monorepo-aware TypeScript type checker.
  * Runs type checking across packages with pretty UI.
diff --git a/scripts/utils/monorepo-helper.mts b/scripts/utils/monorepo-helper.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Monorepo helper utilities for running commands across packages.
  * Provides package detection, file-to-package mapping, and pretty UI for multi-package operations.
diff --git a/scripts/validate-bundle-deps.mts b/scripts/validate-bundle-deps.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Validates that bundled vs external dependencies are correctly declared in package.json.
  *
diff --git a/scripts/validate-no-link-deps.mts b/scripts/validate-no-link-deps.mts
@@ -1,3 +1,5 @@
+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */
+
 /**
  * @fileoverview Validates that no package.json files contain link: dependencies.
  * Link dependencies are prohibited - use workspace: or catalog: instead.

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/* oxlint-disable socket/no-status-emoji -- this file IS the rule definition; emoji literals are lookup-table data, not real usage. */`
	`2`	`+`
`1`	`3`	`/**`
`2`	`4`	`* @fileoverview Ban status-symbol emoji literals (✓ ✔ ❌ ✗ ⚠ ⚠️ ❗ ✅`
`3`	`5`	* ❎ ☑) inside string literals. The `@socketsecurity/lib/logger`
Original file line number	Diff line number	Diff line change
`@@ -290,6 +290,7 @@ async function runStage(stage, ctx, stageParams) {`
`290`	`290`	`)`
`291`	`291`
`292`	`292`	`if (!shouldProceed) {`
	`293`	`+ // oxlint-disable-next-line socket/no-status-emoji -- substep takes its own indent prefix; ✓ marks the cache-hit state.`
`293`	`294`	logger.substep(`✓ ${stage.name} up-to-date (cached)`)
`294`	`295`	`return`
`295`	`296`	`}`
Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,7 @@ export async function createCheckpoint(`
`179`	`179`	await fs.writeFile(file, `${JSON.stringify(data, null, 2)}\n`, 'utf8')
`180`	`180`
`181`	`181`	`const relRoot = packageRoot ? path.relative(packageRoot, file) : file`
	`182`	`+ // oxlint-disable-next-line socket/no-status-emoji -- substep takes its own indent prefix; ✓ marks completion.`
`182`	`183`	logger.substep(`✓ Checkpoint ${name} written (${relRoot})`)
`183`	`184`	`}`
`184`	`185`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/* oxlint-disable socket/no-status-emoji -- dev script output; emoji prefixes provide at-a-glance build/test status. */`
	`2`	`+`
`1`	`3`	`#!/usr/bin/env node`
`2`	`4`	`/**`
`3`	`5`	`* @fileoverview Setup script to install iocraft dev build into node_modules for local testing.`