fix(ci): use standard runners and improve workflow reliability

jdalton · jdalton · commit 4f9b0625e409 · 2025-11-03T08:51:53.000-05:00
Switch all build workflows to standard GitHub runners (ubuntu-latest,
macos-latest, windows-latest) to prevent runner availability issues
and job queuing.

Changes:
- Switch from -8-cores/-xlarge runners to standard runners
- Increase timeouts to compensate for fewer cores
- Fix summary jobs to handle skipped/failed builds properly
- Add build-deps to summary job dependencies
- Add !cancelled() condition to prevent hanging jobs
- Add smoke test to provenance workflow to validate packages before publish
- Improve status reporting with success/failure/skipped detection

This resolves the issue where jobs would queue indefinitely waiting
for specialized runners, and prevents publishing broken packages like
socket@2.1.0.
diff --git a/.github/workflows/build-sea.yml b/.github/workflows/build-sea.yml
@@ -144,12 +144,12 @@ jobs:
             platform: alpine
             arch: arm64
 
-          # macOS builds - use arm64 runner to build both x64 and arm64.
-          - runner: macos-latest-large
+          # macOS builds.
+          - runner: macos-latest
             os: darwin
             platform: darwin
             arch: x64
-          - runner: macos-latest-large
+          - runner: macos-latest
             os: darwin
             platform: darwin
             arch: arm64
@@ -537,32 +537,61 @@ jobs:
 
   summary:
     name: 📊 🌊 SEA Node Build Summary
-    needs: [build-sea]
-    if: always()
+    needs: [build-deps, build-sea]
+    if: always() && !cancelled()
     runs-on: ubuntu-latest
     steps:
       - name: Generate summary
         run: |
           echo "# 🌊 SEA Node Build Summary" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "## ✅ Build Complete" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "SEA (Single Executable Application) binaries built successfully and cached." >> $GITHUB_STEP_SUMMARY
+
+          # Check status of dependencies.
+          DEPS_STATUS="${{ needs.build-deps.result }}"
+          BUILD_STATUS="${{ needs.build-sea.result }}"
+
+          if [ "$DEPS_STATUS" = "failure" ] || [ "$BUILD_STATUS" = "failure" ]; then
+            echo "## ✗ Build Failed" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "One or more builds failed. Check the logs above for details." >> $GITHUB_STEP_SUMMARY
+          elif [ "$DEPS_STATUS" = "skipped" ] && [ "$BUILD_STATUS" = "skipped" ]; then
+            echo "## ⊘ Builds Skipped" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "All builds were skipped (likely due to workflow inputs)." >> $GITHUB_STEP_SUMMARY
+          elif [ "$BUILD_STATUS" = "skipped" ]; then
+            echo "## ⊘ Builds Skipped" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "Builds were skipped (platform builds disabled by workflow inputs)." >> $GITHUB_STEP_SUMMARY
+          else
+            echo "## ✓ Build Complete" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "SEA (Single Executable Application) binaries built successfully and cached." >> $GITHUB_STEP_SUMMARY
+          fi
+
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "### 📦 Build Method" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "| Method | Description | Size |" >> $GITHUB_STEP_SUMMARY
           echo "|--------|-------------|------|" >> $GITHUB_STEP_SUMMARY
           echo "| 🌊 SEA | Single Executable Application | ~70 MB |" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### 🎯 Platforms Built" >> $GITHUB_STEP_SUMMARY
+          echo "### 🎯 Platforms" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "- 🐧 Linux (x64, arm64)" >> $GITHUB_STEP_SUMMARY
-          echo "- 🍎 macOS (x64, arm64)" >> $GITHUB_STEP_SUMMARY
-          echo "- 🪟 Windows (x64, arm64)" >> $GITHUB_STEP_SUMMARY
+          echo "- Linux (x64, arm64)" >> $GITHUB_STEP_SUMMARY
+          echo "- macOS (x64, arm64)" >> $GITHUB_STEP_SUMMARY
+          echo "- Windows (x64, arm64)" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### 🎯 Next Steps" >> $GITHUB_STEP_SUMMARY
+          echo "### → Next Steps" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "- These binaries are now cached for E2E tests" >> $GITHUB_STEP_SUMMARY
-          echo "- Use \`publish-socketbin.yml\` to publish to npm" >> $GITHUB_STEP_SUMMARY
-          echo "- Cache is invalidated when source files change" >> $GITHUB_STEP_SUMMARY
+
+          if [ "$BUILD_STATUS" = "success" ]; then
+            echo "- Binaries cached for E2E tests" >> $GITHUB_STEP_SUMMARY
+            echo "- Use \`publish-socketbin.yml\` to publish" >> $GITHUB_STEP_SUMMARY
+            echo "- Cache invalidated on source changes" >> $GITHUB_STEP_SUMMARY
+          elif [ "$BUILD_STATUS" = "skipped" ]; then
+            echo "- Re-run workflow with platform builds enabled" >> $GITHUB_STEP_SUMMARY
+            echo "- Or use \`workflow_dispatch\` to trigger specific platforms" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "- Check build logs for error details" >> $GITHUB_STEP_SUMMARY
+            echo "- Fix issues and re-run workflow" >> $GITHUB_STEP_SUMMARY
+          fi
diff --git a/.github/workflows/build-smol.yml b/.github/workflows/build-smol.yml
@@ -115,48 +115,48 @@ jobs:
     needs: build-deps
     name: ⚡ Smol - ${{ matrix.platform }}-${{ matrix.arch }}
     runs-on: ${{ matrix.runner }}
-    timeout-minutes: ${{ inputs.force && 150 || 120 }}
+    timeout-minutes: ${{ inputs.force && 180 || 150 }}
     strategy:
       fail-fast: true
       max-parallel: 8
       matrix:
         include:
-          # Linux builds (8-core runners for faster compilation).
-          - runner: ubuntu-latest-8-cores
+          # Linux builds.
+          - runner: ubuntu-latest
             os: linux
             platform: linux
             arch: x64
-          - runner: ubuntu-latest-8-cores
+          - runner: ubuntu-latest
             os: linux
             platform: linux
             arch: arm64
 
           # Alpine Linux builds - use musl binaries from unofficial-builds.nodejs.org.
-          - runner: ubuntu-latest-8-cores
+          - runner: ubuntu-latest
             os: linux
             platform: alpine
             arch: x64
-          - runner: ubuntu-latest-8-cores
+          - runner: ubuntu-latest
             os: linux
             platform: alpine
             arch: arm64
 
-          # macOS builds (8-core runners for faster compilation).
-          - runner: macos-latest-xlarge
+          # macOS builds.
+          - runner: macos-latest
             os: darwin
             platform: darwin
             arch: x64
-          - runner: macos-latest-xlarge
+          - runner: macos-latest
             os: darwin
             platform: darwin
             arch: arm64
 
-          # Windows builds (8-core runners for faster compilation).
-          - runner: windows-latest-8-cores
+          # Windows builds.
+          - runner: windows-latest
             os: windows
             platform: win32
             arch: x64
-          - runner: windows-latest-8-cores
+          - runner: windows-latest
             os: windows
             platform: win32
             arch: arm64
@@ -511,17 +511,37 @@ jobs:
 
   summary:
     name: ⚡ Build Summary
-    needs: [build-smol]
-    if: always()
+    needs: [build-deps, build-smol]
+    if: always() && !cancelled()
     runs-on: ubuntu-latest
     steps:
       - name: Generate summary
         run: |
           echo "# ⚡ Socket Smol Node Build" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "## ✓ Build Complete" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "Socket smol binaries (compressed Node.js + CLI) built successfully." >> $GITHUB_STEP_SUMMARY
+
+          # Check status of dependencies.
+          DEPS_STATUS="${{ needs.build-deps.result }}"
+          BUILD_STATUS="${{ needs.build-smol.result }}"
+
+          if [ "$DEPS_STATUS" = "failure" ] || [ "$BUILD_STATUS" = "failure" ]; then
+            echo "## ✗ Build Failed" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "One or more builds failed. Check the logs above for details." >> $GITHUB_STEP_SUMMARY
+          elif [ "$DEPS_STATUS" = "skipped" ] && [ "$BUILD_STATUS" = "skipped" ]; then
+            echo "## ⊘ Builds Skipped" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "All builds were skipped (likely due to workflow inputs)." >> $GITHUB_STEP_SUMMARY
+          elif [ "$BUILD_STATUS" = "skipped" ]; then
+            echo "## ⊘ Builds Skipped" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "Builds were skipped (platform builds disabled by workflow inputs)." >> $GITHUB_STEP_SUMMARY
+          else
+            echo "## ✓ Build Complete" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "Socket smol binaries (compressed Node.js + CLI) built successfully." >> $GITHUB_STEP_SUMMARY
+          fi
+
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "### ⚡ Socket Smol Method" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
@@ -537,6 +557,15 @@ jobs:
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "### → Next Steps" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "- Binaries cached for E2E tests" >> $GITHUB_STEP_SUMMARY
-          echo "- Use \`publish-socketbin.yml\` to publish" >> $GITHUB_STEP_SUMMARY
-          echo "- Cache invalidated on patch/script changes" >> $GITHUB_STEP_SUMMARY
+
+          if [ "$BUILD_STATUS" = "success" ]; then
+            echo "- Binaries cached for E2E tests" >> $GITHUB_STEP_SUMMARY
+            echo "- Use \`publish-socketbin.yml\` to publish" >> $GITHUB_STEP_SUMMARY
+            echo "- Cache invalidated on patch/script changes" >> $GITHUB_STEP_SUMMARY
+          elif [ "$BUILD_STATUS" = "skipped" ]; then
+            echo "- Re-run workflow with platform builds enabled" >> $GITHUB_STEP_SUMMARY
+            echo "- Or use \`workflow_dispatch\` to trigger specific platforms" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "- Check build logs for error details" >> $GITHUB_STEP_SUMMARY
+            echo "- Fix issues and re-run workflow" >> $GITHUB_STEP_SUMMARY
+          fi
diff --git a/.github/workflows/build-wasm.yml b/.github/workflows/build-wasm.yml
@@ -492,7 +492,7 @@ jobs:
 
   summary:
     name: 📊 🧱 WASM Build Summary
-    if: always()
+    if: always() && !cancelled()
     needs: [build-yoga-layout, build-models, build-onnx-runtime]
     runs-on: ubuntu-latest
     steps:
@@ -506,33 +506,83 @@ jobs:
         run: |
           echo "# 🧱 WASM Build Summary" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "## ✅ Build Complete" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo "Selected WASM assets built successfully and cached." >> $GITHUB_STEP_SUMMARY
+
+          # Check status of builds.
+          YOGA_STATUS="${{ needs.build-yoga-layout.result }}"
+          MODELS_STATUS="${{ needs.build-models.result }}"
+          ONNX_STATUS="${{ needs.build-onnx-runtime.result }}"
+
+          # Determine overall status.
+          if [ "$YOGA_STATUS" = "failure" ] || [ "$MODELS_STATUS" = "failure" ] || [ "$ONNX_STATUS" = "failure" ]; then
+            echo "## ✗ Build Failed" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "One or more builds failed. Check the logs above for details." >> $GITHUB_STEP_SUMMARY
+          elif [ "$YOGA_STATUS" = "skipped" ] && [ "$MODELS_STATUS" = "skipped" ] && [ "$ONNX_STATUS" = "skipped" ]; then
+            echo "## ⊘ Builds Skipped" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "All builds were skipped (likely due to workflow inputs)." >> $GITHUB_STEP_SUMMARY
+          else
+            echo "## ✓ Build Complete" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "Selected WASM assets built successfully and cached." >> $GITHUB_STEP_SUMMARY
+          fi
+
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "### 📦 Artifacts" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "| Asset | Files |" >> $GITHUB_STEP_SUMMARY
-          echo "|-------|-------|" >> $GITHUB_STEP_SUMMARY
-          if [ -d "artifacts/yoga-wasm" ]; then
-            echo "| 🧘 Yoga Layout | \`yoga.wasm\`, \`yoga.js\` |" >> $GITHUB_STEP_SUMMARY
+          echo "| Asset | Status | Files |" >> $GITHUB_STEP_SUMMARY
+          echo "|-------|--------|-------|" >> $GITHUB_STEP_SUMMARY
+
+          # Yoga Layout.
+          if [ "$YOGA_STATUS" = "success" ]; then
+            echo "| 🧘 Yoga Layout | ✓ | \`yoga.wasm\`, \`yoga.js\` |" >> $GITHUB_STEP_SUMMARY
+          elif [ "$YOGA_STATUS" = "skipped" ]; then
+            echo "| 🧘 Yoga Layout | ⊘ | Skipped |" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "| 🧘 Yoga Layout | ✗ | Failed |" >> $GITHUB_STEP_SUMMARY
           fi
-          if [ -d "artifacts/ai-models" ]; then
-            # Detect quantization level from file names.
-            if [ -f "artifacts/ai-models/minilm-l6-int8.onnx" ]; then
-              echo "| 🤖 AI Models | \`minilm-l6-int8.onnx\` (INT8), \`codet5-encoder-int8.onnx\` (INT8), \`codet5-decoder-int8.onnx\` (INT8) |" >> $GITHUB_STEP_SUMMARY
-            elif [ -f "artifacts/ai-models/minilm-l6-int4.onnx" ]; then
-              echo "| 🤖 AI Models | \`minilm-l6-int4.onnx\` (INT4), \`codet5-encoder-int4.onnx\` (INT4), \`codet5-decoder-int4.onnx\` (INT4) |" >> $GITHUB_STEP_SUMMARY
+
+          # AI Models.
+          if [ "$MODELS_STATUS" = "success" ]; then
+            if [ -d "artifacts/ai-models" ]; then
+              if [ -f "artifacts/ai-models/minilm-l6-int8.onnx" ]; then
+                echo "| 🤖 AI Models | ✓ | \`*-int8.onnx\` (INT8) |" >> $GITHUB_STEP_SUMMARY
+              elif [ -f "artifacts/ai-models/minilm-l6-int4.onnx" ]; then
+                echo "| 🤖 AI Models | ✓ | \`*-int4.onnx\` (INT4) |" >> $GITHUB_STEP_SUMMARY
+              else
+                echo "| 🤖 AI Models | ✓ | Built |" >> $GITHUB_STEP_SUMMARY
+              fi
             else
-              echo "| 🤖 AI Models | $(ls artifacts/ai-models/*.onnx 2>/dev/null | xargs -n1 basename | sed 's/^/`/;s/$/`/' | tr '\n' ',' | sed 's/,$//' || echo "No ONNX files found") |" >> $GITHUB_STEP_SUMMARY
+              echo "| 🤖 AI Models | ✓ | Built |" >> $GITHUB_STEP_SUMMARY
             fi
+          elif [ "$MODELS_STATUS" = "skipped" ]; then
+            echo "| 🤖 AI Models | ⊘ | Skipped |" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "| 🤖 AI Models | ✗ | Failed |" >> $GITHUB_STEP_SUMMARY
           fi
-          if [ -d "artifacts/onnx-runtime" ]; then
-            echo "| 🌐 ONNX Runtime | \`ort-wasm-simd-threaded.wasm\`, \`ort-wasm-simd-threaded.mjs\` |" >> $GITHUB_STEP_SUMMARY
+
+          # ONNX Runtime.
+          if [ "$ONNX_STATUS" = "success" ]; then
+            echo "| 🌐 ONNX Runtime | ✓ | \`ort-wasm-simd-threaded.*\` |" >> $GITHUB_STEP_SUMMARY
+          elif [ "$ONNX_STATUS" = "skipped" ]; then
+            echo "| 🌐 ONNX Runtime | ⊘ | Skipped |" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "| 🌐 ONNX Runtime | ✗ | Failed |" >> $GITHUB_STEP_SUMMARY
           fi
+
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "### 🎯 Next Steps" >> $GITHUB_STEP_SUMMARY
+          echo "### → Next Steps" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "- These artifacts are now cached for CI builds" >> $GITHUB_STEP_SUMMARY
-          echo "- CLI builds will use these cached WASM assets" >> $GITHUB_STEP_SUMMARY
-          echo "- Cache is invalidated when source files change" >> $GITHUB_STEP_SUMMARY
+
+          # Check if any succeeded.
+          if [ "$YOGA_STATUS" = "success" ] || [ "$MODELS_STATUS" = "success" ] || [ "$ONNX_STATUS" = "success" ]; then
+            echo "- Artifacts cached for CI builds" >> $GITHUB_STEP_SUMMARY
+            echo "- CLI builds will use cached WASM assets" >> $GITHUB_STEP_SUMMARY
+            echo "- Cache invalidated on source changes" >> $GITHUB_STEP_SUMMARY
+          elif [ "$YOGA_STATUS" = "skipped" ] && [ "$MODELS_STATUS" = "skipped" ] && [ "$ONNX_STATUS" = "skipped" ]; then
+            echo "- Re-run workflow with builds enabled" >> $GITHUB_STEP_SUMMARY
+            echo "- Or use \`workflow_dispatch\` to build specific assets" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "- Check build logs for error details" >> $GITHUB_STEP_SUMMARY
+            echo "- Fix issues and re-run workflow" >> $GITHUB_STEP_SUMMARY
+          fi
diff --git a/.github/workflows/provenance.yml b/.github/workflows/provenance.yml
@@ -83,6 +83,31 @@ jobs:
       - name: Validate socket package
         if: ${{ inputs.publish-socket != false }}
         run: pnpm --filter socket run verify
+      - name: Smoke test socket package
+        if: ${{ inputs.publish-socket != false }}
+        run: |
+          echo "Running smoke test on socket package..."
+          cd packages/socket
+
+          # Pack the package locally (doesn't publish).
+          npm pack
+
+          # Install it in a temp directory.
+          TEMP_DIR=$(mktemp -d)
+          cd "$TEMP_DIR"
+          npm install --no-save "$OLDPWD"/socket-*.tgz
+
+          # Test basic commands.
+          echo "Testing: socket --version"
+          npx socket --version || (echo "✗ socket --version failed" && exit 1)
+
+          echo "Testing: socket --help"
+          npx socket --help || (echo "✗ socket --help failed" && exit 1)
+
+          echo "✓ Smoke test passed"
+
+          # Cleanup.
+          rm -rf "$TEMP_DIR"
       - name: Publish socket package
         if: ${{ inputs.publish-socket != false }}
         working-directory: packages/socket
