Skip to content

Commit 6390fea

Browse files
committed
docs(manifest/bazel): drop plan-doc finding labels from comments
1 parent 210099b commit 6390fea

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/commands/manifest/bazel/bazel-cquery.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ const EDGE_ATTR_NAMES: ReadonlySet<string> = new Set([
102102
// (Bazel-native java_library / kt_jvm_import shape).
103103
// Note: a `maven_url`-only predicate was intentionally dropped — those rules
104104
// carry no coordinate, so selecting them only to discard them downstream is
105-
// wasted analysis (finding G). If POM-only artifacts ever matter, synthesize
105+
// wasted analysis. If POM-only artifacts ever matter, synthesize
106106
// a coordinate from `maven_url` instead of re-adding the selector.
107107
function buildMetadataCqueryExpr(repoName: string): string {
108108
const r = `@${repoName}//...`

src/commands/manifest/bazel/bazel-cquery.test.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ describe('buildMetadataCqueryArgv', () => {
146146
const expr = argv.find(a => a.includes('attr("tags"'))
147147
expect(expr).toContain('attr("tags", "\\bmaven_coordinates=", @maven//...)')
148148
expect(expr).toContain('attr("maven_coordinates", ".+", @maven//...)')
149-
// maven_url selector dropped (finding G).
149+
// maven_url selector dropped: those rules carry no coordinate.
150150
expect(expr).not.toContain('maven_url')
151151
})
152152

src/commands/manifest/bazel/extract_bazel_to_maven.mts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const REAP_TIMEOUT_MS = 10_000
9090
// Default directory-prune policy for the Bazel workspace walk. The
9191
// orchestrator applies this unconditionally so neither caller (the explicit
9292
// `socket manifest bazel` command nor `--auto-manifest`) can omit it and let
93-
// the walk descend `node_modules`/VCS/vendored trees (finding A). Callers may
93+
// the walk descend `node_modules`/VCS/vendored trees. Callers may
9494
// pass extra names/prefixes to EXTEND, not replace, this set.
9595
export const DEFAULT_BAZEL_WALKER_IGNORE_DIR_NAMES: ReadonlySet<string> =
9696
new Set([
@@ -519,8 +519,8 @@ export async function extractBazelToMaven(
519519
let hubsFailed = 0
520520

521521
try {
522-
// Always apply the default prune policy so no caller can forget it
523-
// (finding A); callers EXTEND it via ignoreDirNames/ignoreDirPrefixes.
522+
// Always apply the default prune policy so no caller can forget it;
523+
// callers EXTEND it via ignoreDirNames/ignoreDirPrefixes.
524524
const ignoreDirNames = new Set([
525525
...DEFAULT_BAZEL_WALKER_IGNORE_DIR_NAMES,
526526
...(opts.ignoreDirNames ?? []),

0 commit comments

Comments
 (0)