Commit 988c6bb
committed
fix(types,quality): revert Object.create(undefined) regression + finish null→undefined flip
Resolves task #51.
Critical fixes:
* Object.create(undefined) → Object.create(null) across 6 files
(packages/cli/{src/utils,test/helpers}, test/unit/bootstrap). The
prior autofix replaced `null` with `undefined`, which makes
Object.create throw a TypeError at runtime — `null` is the
documented prototype sentinel.
* packages/cli/scripts/wasm.mts: unterminated string literal
('Keeping existing file\n') fixed.
Type alignment with the prior null→undefined autofix:
* 18 packages/cli/src/{commands,utils,test} files: `T | null` types
flipped to `T | undefined` to match call-site values.
* detect-manifest-actions.mts: `sockJson: SocketJson | null` →
`| undefined` (param's sentinel meaning was already undefined-based;
comment updated to match).
* test-builder.mts, cli-process-pool.mts: pool refs flipped.
SDK schema literals (`nextPage: string | null` returned by the public
SDK) kept their `null` value with inline disables — the schema is
external API contract.
Also picks up the sort-source-methods autofix from socket-wheelhouse.
Iterated `oxlint --fix` to convergence: 1729 → 1472 lint violations
(no-dynamic-import / no-status-emoji / prefer-exists-sync need
judgment-call fixes that the autofix doesn't attempt).1 parent e74da4d commit 988c6bb
334 files changed
Lines changed: 7519 additions & 7049 deletions
File tree
- .claude/hooks
- claude-md-size-guard
- no-revert-guard
- .config/oxlint-plugin/rules
- docs
- packages
- build-infra/lib
- release-checksums
- cli
- .config
- scripts
- constants
- sea-build-utils
- utils
- src
- bootstrap
- commands
- analytics
- ask
- audit-log
- config
- fix
- install
- manifest
- mcp
- lib
- optimize
- organization
- package
- pip
- raw-npm
- raw-npx
- repository
- scan
- threat-feed
- uninstall
- whoami
- constants
- env
- test
- mocks
- utils
- basics
- cli
- command
- data
- dlx
- dry-run
- ecosystem
- error
- git
- npm
- output
- adapters
- process
- project
- sea
- socket
- spawn
- telemetry
- terminal
- update
- validation
- test
- e2e
- helpers
- integration
- api
- binary
- cli
- unit
- commands
- analytics
- ask
- bundler
- cargo
- config
- fix
- gem
- go
- install
- json
- login
- logout
- manifest
- mcp
- lib
- nuget
- optimize
- organization
- package
- pycli
- repository
- scan
- sfw
- threat-feed
- uninstall
- uv
- wrapper
- constants
- env
- test
- utils
- basics
- cli
- coana
- command
- dlx
- dry-run
- ecosystem
- error
- fs
- git
- npm
- output
- preflight
- process
- project
- sea
- socket
- spawn
- telemetry
- terminal
- update
- yarn
- package-builder
- scripts
- templates
- cli-package/.config
- cli-sentry-package/.config
- socketaddon-main
- scripts
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
0 commit comments