You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Address review feedback on the maven PR:
- CHANGELOG: the new section is the 1.1.125 release (per package.json after
the v1.x merge), so relabel its heading `1.1.124` -> `1.1.125` (the link
target was already v1.1.125).
- `--gradle-opts` / `--sbt-opts` / `--maven-opts` were split on every space,
shredding a value with a spaced path (e.g. `-s "my settings.xml"`) into
separate tokens. Introduce a shared quote-aware tokenizer
(`parseBuildToolOpts`) honoring single/double quotes and use it across all
manifest opts sites (gradle/kotlin/scala/maven + auto-manifest) so the fix
is consistent rather than a maven-only divergence. Unquoted input tokenizes
exactly as before.
- New `socket manifest maven` command generates a Socket facts file (`.socket.facts.json`) directly from a Maven `pom.xml` project. Like the Gradle and sbt generators, it auto-detects your project, plugs into `socket manifest auto` and the `socket manifest setup` configurator, and accepts `--maven-opts` to pass options through to Maven (e.g. `--maven-opts="-P release -s settings.xml"`), plus `--bin` to point at a wrapper such as `./mvnw`.
0 commit comments