fix(lint): clear remaining socket/* rule violations in cli package

- prefer-cached-for-loop: cache array.length in for-loops; oxlint
  autofix where safe, inline disables on patterns the rule flags as
  unsafe (destructured loop variable, non-bare-identifier iterable)
- no-default-export: convert ENV, meow, runNpmCli/runNpxCli/runPnpmCli/
  runYarnCli, and the constants barrel to named exports; update all
  call sites; oxlint-disable on the three vitest configs (vitest API
  requires default export)
- prefer-separate-type-import: split mixed value/type imports
  (autofix handled all 9 sites)

Also fixes two pre-existing iteration bugs uncovered while triaging:
  - errors.mts calculateStringSimilarity iterated a Set with cached
    `.length` (Set has no .length / no numeric index), always
    returning 0 instead of the word-overlap ratio
  - utils/socket/package-alert.mts and utils/fs/glob.mts similarly
    iterated Sets with cached-length loops; converted back to for-of

Author: jdalton

.config/oxlintrc.json

@@ -1,13 +1,7 @@
 {
   "$schema": "https://raw.githubusercontent.com/oxc-project/oxc/main/npm/oxlint/configuration_schema.json",
-  "plugins": [
-    "typescript",
-    "unicorn",
-    "import"
-  ],
-  "jsPlugins": [
-    "./oxlint-plugin/index.mts"
-  ],
+  "plugins": ["typescript", "unicorn", "import"],
+  "jsPlugins": ["./oxlint-plugin/index.mts"],
   "categories": {
     "correctness": "error",
     "suspicious": "error"

.config/tsconfig.json

@@ -4,10 +4,7 @@
     "declarationMap": false,
     "sourceMap": false
   },
-  "include": [
-    "../src/**/*.mts",
-    "../src/**/*.d.ts"
-  ],
+  "include": ["../src/**/*.mts", "../src/**/*.d.ts"],
   "exclude": [
     "../src/**/*.test.mts",
     "../src/**/*.tsx",

packages/cli/.config/esbuild.cli.mts

@@ -40,7 +40,10 @@ export function findSocketLibPath(importerPath: string) {
   return undefined
 }
 
-export function resolveSocketLibExternal(socketLibPath: string, packageName: string) {
+export function resolveSocketLibExternal(
+  socketLibPath: string,
+  packageName: string,
+) {
   if (packageName.startsWith('@')) {
     const parts = packageName.split('/')
     const scope = parts[0]!

packages/cli/scripts/build-sea.mts

@@ -137,7 +137,8 @@ async function main() {
   logger.log(
     `Building ${targets.length} target${targets.length > 1 ? 's' : ''}:`,
   )
-  for (const target of targets) {
+  for (let i = 0, { length } = targets; i < length; i += 1) {
+    const target = targets[i]
     logger.log(`  - ${target.platform}-${target.arch}`)
   }
   logger.log('')

packages/cli/scripts/build.mts

@@ -57,7 +57,8 @@ export async function fixNodeGypStrings(dir, options = {}) {
   // Find all .js files in build directory.
   const files = await fs.readdir(dir, { withFileTypes: true })
 
-  for (const file of files) {
+  for (let i = 0, { length } = files; i < length; i += 1) {
+    const file = files[i]
     const filePath = path.join(dir, file.name)
 
     if (file.isDirectory()) {
@@ -169,7 +170,8 @@ async function main() {
       }).then(result => ({ name: 'Download Assets', result })),
     ])
 
-    for (const settled of parallelPrep) {
+    for (let i = 0, { length } = parallelPrep; i < length; i += 1) {
+      const settled = parallelPrep[i]
       if (settled.status === 'rejected') {
         if (!quiet) {
           logger.error(`Parallel preparation failed: ${settled.reason}`)
@@ -274,7 +276,8 @@ async function main() {
 
     const postFailed = postResults.filter(r => r.status === 'rejected')
     if (postFailed.length > 0) {
-      for (const r of postFailed) {
+      for (let i = 0, { length } = postFailed; i < length; i += 1) {
+        const r = postFailed[i]
         logger.error(`Post-processing failed: ${r.reason?.message ?? r.reason}`)
       }
       throw new Error('Post-processing step(s) failed')

packages/cli/scripts/download-assets.mts

@@ -152,15 +152,17 @@ async function downloadAssets(assetNames, parallel = true) {
     )
     if (failed.length > 0) {
       logger.error(`\n${failed.length} asset(s) failed:`)
-      for (const r of failed) {
+      for (let i = 0, { length } = failed; i < length; i += 1) {
+        const r = failed[i]
         logger.error(
           `  - ${r.status === 'rejected' ? (r.reason?.message ?? r.reason) : r.value.name}`,
         )
       }
       process.exitCode = 1
     }
   } else {
-    for (const name of assetNames) {
+    for (let i = 0, { length } = assetNames; i < length; i += 1) {
+      const name = assetNames[i]
       const result = await downloadAsset(ASSETS[name])
       if (!result.ok && !result.skipped) {
         process.exitCode = 1
@@ -247,7 +249,8 @@ async function main() {
   const assetNames = assetArgs.length > 0 ? assetArgs : Object.keys(ASSETS)
 
   // Validate asset names.
-  for (const name of assetNames) {
+  for (let i = 0, { length } = assetNames; i < length; i += 1) {
+    const name = assetNames[i]
     if (!(name in ASSETS)) {
       logger.error(`Unknown asset: ${name}`)
       logger.error(`Available assets: ${Object.keys(ASSETS).join(', ')}`)

packages/cli/scripts/environment-variables.mts

@@ -189,6 +189,7 @@ export class EnvironmentVariables {
 
     // Convert all values to JSON-stringified format for esbuild.
     const defines: Record<string, string> = {}
+    // oxlint-disable-next-line socket/prefer-cached-for-loop -- loop variable is destructured
     for (const [key, value] of Object.entries(envVars)) {
       defines[key] = JSON.stringify(value)
     }

packages/cli/scripts/esbuild-utils.mts

@@ -50,6 +50,7 @@ export function createBaseConfig(
  */
 export function createDefineEntries(envVars: Record<string, string>) {
   const entries: Record<string, string> = {}
+  // oxlint-disable-next-line socket/prefer-cached-for-loop -- loop variable is destructured
   for (const [key, value] of Object.entries(envVars)) {
     // Dot notation: process.env.KEY
     entries[`process.env.${key}`] = value
@@ -96,11 +97,13 @@ export function envVarReplacementPlugin(envVars: Record<string, string>) {
           return
         }
 
-        for (const output of outputs) {
+        for (let i = 0, { length } = outputs; i < length; i += 1) {
+          const output = outputs[i]
           let content = output.text
 
           // Replace all forms of process.env["KEY"] access, even with mangled identifiers.
           // Pattern: <anything>.env["KEY"] where <anything> could be "import_node_process21.default" etc.
+          // oxlint-disable-next-line socket/prefer-cached-for-loop -- loop variable is destructured
           for (const [key, value] of Object.entries(envVars)) {
             // Match: <identifier>.env["KEY"] or <identifier>.env['KEY']
             const pattern = new RegExp(`(\\w+\\.)+env\\["${key}"\\]`, 'g')
@@ -149,6 +152,7 @@ export async function runBuild(config: BuildOptions, description = 'Build') {
 
     // If write: false, manually write outputFiles.
     if (result.outputFiles && result.outputFiles.length > 0) {
+      // oxlint-disable-next-line socket/prefer-cached-for-loop -- iterable is not a bare identifier (could be Map/Set/Generator/expression)
       for (const output of result.outputFiles) {
         mkdirSync(path.dirname(output.path), { recursive: true })
         writeFileSync(output.path, output.contents)

packages/cli/scripts/generate-packages.mts

@@ -19,7 +19,8 @@ const scripts = [
   path.join(packageBuilderScripts, 'generate-socketbin-packages.mts'),
 ]
 
-for (const script of scripts) {
+for (let i = 0, { length } = scripts; i < length; i += 1) {
+  const script = scripts[i]
   const result = await spawn('node', [script], { stdio: 'inherit' })
 
   if (!result) {

packages/cli/scripts/restore-cache.mts

@@ -171,7 +171,8 @@ export async function hashFiles(globPattern, cwd) {
       return 'none'
     }
     const hash = createHash('sha256')
-    for (const file of files) {
+    for (let i = 0, { length } = files; i < length; i += 1) {
+      const file = files[i]
       const content = await fs.readFile(path.join(cwd, file), 'utf8')
       hash.update(content)
     }