chore(cleanup): trim dead helpers from flags.mts, bootstrap/paths.mts, util/ipc.mts

  flags.mts: drop validationFlags (defineFlags const with zero src
    consumers; test only verified its shape — describe block also
    deleted). Kept resetFlagCache (test-only utility, but it's a
    legitimate testability hook — the V8 space-size flag getters cache
    their first read; tests need a reset to exercise different env
    values; flagged @internal).
  util/ipc.mts: drop initializeIpc, getIpcExtra, getBootstrapBinaryPath
    (3 functions + supporting module state). Keep the IpcObject type
    (imported by util/dlx/spawn.mts via `import type`). Delete the
    test file — all its blocks tested the now-removed functions.
  bootstrap/shared/paths.mts: drop getBootstrapBinaryDir + getRegistryUrl
    (both zero src consumers). Test blocks for both deleted.

Author: jdalton

packages/cli/src/bootstrap/shared/paths.mts

@@ -12,14 +12,6 @@
 import os from 'node:os'
 import path from 'node:path'
 
-/**
- * Get the bootstrap binary installation directory. This is where SEA/yao-pkg
- * executables are cached.
- */
-export function getBootstrapBinaryDir(): string {
-  return path.join(getSocketHome(), '_cli')
-}
-
 /**
  * Get the CLI entry point path.
  */
@@ -50,18 +42,6 @@ export function getDlxDir(): string {
   return path.join(getSocketHome(), '_dlx')
 }
 
-/**
- * Get npm registry URL with environment variable support. Direct process.env
- * access required - bootstrap runs before ENV module loads.
- */
-export function getRegistryUrl(): string {
-  return (
-    process.env['SOCKET_NPM_REGISTRY'] ||
-    process.env['NPM_REGISTRY'] ||
-    'https://registry.npmjs.org'
-  )
-}
-
 /**
  * Get the Socket home directory path. Supports SOCKET_HOME environment variable
  * override. Direct process.env access required - bootstrap runs before ENV

packages/cli/src/flags.mts

@@ -181,7 +181,9 @@ export function getRawSpaceSizeFlags(): RawSpaceSizeFlags {
 }
 
 /**
- * Reset cached flag values for testing purposes.
+ * Reset cached flag values. Test-only — the V8 space-size flag getters
+ * memoize their first read of process.execArgv + process.env; tests need
+ * a way to clear the cache between assertions over different env values.
  *
  * @internal
  */
@@ -190,6 +192,7 @@ export function resetFlagCache(): void {
   maxOldSpaceSizeFlag = undefined
   maxSemiSpaceSizeFlag = undefined
 }
+
 // Ensure export because dist/flags.js is required in src/constants.mts.
 if (typeof exports === 'object' && exports !== null) {
   exports.getMaxSemiSpaceSizeFlag = getMaxSemiSpaceSizeFlag
@@ -302,15 +305,3 @@ export const outputFlags = defineFlags({
   },
 })
 
-export const validationFlags = defineFlags({
-  all: {
-    type: 'boolean',
-    default: false,
-    description: 'Include all issues',
-  },
-  strict: {
-    type: 'boolean',
-    default: false,
-    description: 'Exits with an error code if any matching issues are found',
-  },
-})

packages/cli/src/util/ipc.mts

@@ -1,62 +1,10 @@
 /**
- * IPC data handling for subprocess communication.
- *
- * Provides access to IPC data passed via bootstrap handshake. The handshake
- * includes configuration like fix/optimize modes and other settings needed by
- * spawned processes.
+ * IPC types for subprocess communication. Used as the typed shape of the
+ * `ipc` field in spawn options when launching child Socket CLI processes.
  */
 
-import { waitForBootstrapHandshake } from './sea/boot.mjs'
-
 // IpcObject type for subprocess IPC data.
 export type IpcObject = Readonly<{
   SOCKET_CLI_FIX?: string | undefined
   SOCKET_CLI_OPTIMIZE?: boolean | undefined
 }>
-
-// Store for IPC extra data received via handshake.
-let ipcExtra: IpcObject | undefined
-
-// Store for bootstrap binary path received via handshake.
-let bootstrapBinaryPath: string | undefined
-
-/**
- * Get bootstrap binary path from handshake. Returns the path to the bootstrap
- * wrapper that launched this CLI instance. Only available when CLI was launched
- * via a bootstrap wrapper (e.g., npx socket).
- */
-export function getBootstrapBinaryPath(): string | undefined {
-  return bootstrapBinaryPath
-}
-
-/**
- * Get IPC extra data from handshake. Returns the extra field from the bootstrap
- * handshake.
- */
-export function getIpcExtra(): IpcObject | undefined {
-  return ipcExtra
-}
-
-/**
- * Initialize IPC data handling. Waits for the bootstrap handshake and extracts
- * the extra field.
- */
-export async function initializeIpc(): Promise<void> {
-  try {
-    const handshake = await waitForBootstrapHandshake(1000)
-    if (handshake?.['extra']) {
-      const extra = handshake['extra'] as Record<string, unknown>
-
-      // Extract bootstrap binary path if provided.
-      if (typeof extra['bootstrapBinaryPath'] === 'string') {
-        bootstrapBinaryPath = extra['bootstrapBinaryPath']
-      }
-
-      // Extract IPC data (excluding bootstrap metadata).
-      const { bootstrapBinaryPath: _, ...ipcData } = extra
-      ipcExtra = ipcData as IpcObject
-    }
-  } catch {
-    // No handshake - running without IPC.
-  }
-}

packages/cli/test/unit/bootstrap/shared/paths.test.mts

@@ -13,12 +13,10 @@ import path from 'node:path'
 import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 
 import {
-  getBootstrapBinaryDir,
   getCliEntryPoint,
   getCliPackageDir,
   getCliPackageName,
   getDlxDir,
-  getRegistryUrl,
   getSocketHome,
 } from '../../../../src/bootstrap/shared/paths.mts'
 
@@ -70,13 +68,6 @@ describe('bootstrap/shared/paths', () => {
     })
   })
 
-  describe('getBootstrapBinaryDir', () => {
-    it('appends _cli to the socket home', () => {
-      process.env['SOCKET_HOME'] = '/x'
-      expect(getBootstrapBinaryDir()).toBe(path.join('/x', '_cli'))
-    })
-  })
-
   describe('getDlxDir', () => {
     it('appends _dlx to the socket home', () => {
       process.env['SOCKET_HOME'] = '/x'
@@ -100,28 +91,6 @@ describe('bootstrap/shared/paths', () => {
     })
   })
 
-  describe('getRegistryUrl', () => {
-    it('uses SOCKET_NPM_REGISTRY when set', () => {
-      process.env['SOCKET_NPM_REGISTRY'] = 'https://socket-registry.example/'
-      expect(getRegistryUrl()).toBe('https://socket-registry.example/')
-    })
-
-    it('uses NPM_REGISTRY when SOCKET_NPM_REGISTRY is missing', () => {
-      process.env['NPM_REGISTRY'] = 'https://npm-registry.example/'
-      expect(getRegistryUrl()).toBe('https://npm-registry.example/')
-    })
-
-    it('falls back to the public npm registry', () => {
-      expect(getRegistryUrl()).toBe('https://registry.npmjs.org')
-    })
-
-    it('prefers SOCKET_NPM_REGISTRY over NPM_REGISTRY', () => {
-      process.env['SOCKET_NPM_REGISTRY'] = 'https://socket-r.example/'
-      process.env['NPM_REGISTRY'] = 'https://npm-r.example/'
-      expect(getRegistryUrl()).toBe('https://socket-r.example/')
-    })
-  })
-
   describe('getCliPackageName', () => {
     it('uses SOCKET_CLI_PACKAGE when set', () => {
       process.env['SOCKET_CLI_PACKAGE'] = '@my-org/socket'

packages/cli/test/unit/flags.test.mts

@@ -67,7 +67,6 @@ import {
   getMaxSemiSpaceSizeFlag,
   outputFlags,
   resetFlagCache,
-  validationFlags,
 } from '../../src/flags.mts'
 
 import type * as OsModule from 'node:os'
@@ -302,32 +301,4 @@ describe('flags', () => {
     })
   })
 
-  describe('validationFlags', () => {
-    it('exports validation-related flags', () => {
-      expect(validationFlags).toBeDefined()
-      expect(typeof validationFlags).toBe('object')
-
-      // Check for expected validation flags.
-      expect(validationFlags).toHaveProperty('all')
-      expect(validationFlags).toHaveProperty('strict')
-
-      // Check flag types.
-      expect(validationFlags.all?.type).toBe('boolean')
-      expect(validationFlags.strict?.type).toBe('boolean')
-    })
-
-    it('has descriptions for all flags', () => {
-      for (const [, flag] of Object.entries(validationFlags)) {
-        expect(flag).toHaveProperty('description')
-        expect(typeof flag.description).toBe('string')
-        expect(flag.description.length).toBeGreaterThan(0)
-      }
-    })
-
-    it('validation flags do not have short flags', () => {
-      // Validation flags don't have short flags by design.
-      expect(validationFlags.all?.shortFlag).toBeUndefined()
-      expect(validationFlags.strict?.shortFlag).toBeUndefined()
-    })
-  })
 })