refactor(scripts): add missing type annotations to 3 more functions

- fix/commonjs-exports.mts: processDirectory(dir: string, verbose: boolean): Promise<number>
- validate/external-types.mts: getDtsFilesRecursive(dir: string, files: string[]): string[]
- build-externals/esbuild-config.mts: createStubPlugin(stubMap: Record<string, string>)

Author: jdalton

scripts/build-externals/esbuild-config.mts

@@ -143,11 +143,9 @@ function createForceNodeModulesPlugin() {
 
 /**
  * Create esbuild plugin to stub modules using files from stubs/ directory.
- *
- * @param {Record<string, string>} stubMap - Map of regex patterns to stub filenames
- * @returns {import('esbuild').Plugin}
+ * stubMap keys are regex patterns; values are stub filenames.
  */
-function createStubPlugin(stubMap = STUB_MAP) {
+function createStubPlugin(stubMap: Record<string, string> = STUB_MAP) {
   // Pre-compile regex patterns and load stub contents
   const stubs = Object.entries(stubMap).map(([pattern, filename]) => ({
     filter: new RegExp(pattern),

scripts/fix/commonjs-exports.mts

@@ -22,12 +22,11 @@ const distDir = path.resolve(__dirname, '..', '..', 'dist')
 /**
  * Process files in a directory and fix CommonJS exports.
  * Handles files with `export default` by transforming __toCommonJS patterns.
- *
- * @param {string} dir - Directory to process
- * @param {boolean} verbose - Show individual file fixes
- * @returns {Promise<number>} Number of files fixed
  */
-async function processDirectory(dir, verbose = false) {
+async function processDirectory(
+  dir: string,
+  verbose: boolean = false,
+): Promise<number> {
   let fixedCount = 0
 
   try {

scripts/validate/external-types.mts

@@ -31,7 +31,7 @@ const logger = getDefaultLogger()
 /**
  * Get all .d.ts files recursively in a directory.
  */
-function getDtsFilesRecursive(dir, files = []) {
+function getDtsFilesRecursive(dir: string, files: string[] = []): string[] {
   try {
     const entries = readdirSync(dir, { withFileTypes: true })