From 21e77455960b9b0cdf9bb0f052d83c69dca3cb7f Mon Sep 17 00:00:00 2001
From: Katie Strader <kstrader@specterops.io>
Date: Thu, 26 Jun 2025 13:50:04 -0700
Subject: [PATCH] fix: BED-6026 adding the domainSid to _unresolvablePrincipals
 cache to prevent repeated resolving

---
 src/CommonLib/LdapUtils.cs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/CommonLib/LdapUtils.cs b/src/CommonLib/LdapUtils.cs
index 6d847c31d..27777c725 100644
--- a/src/CommonLib/LdapUtils.cs
+++ b/src/CommonLib/LdapUtils.cs
@@ -383,6 +383,8 @@ public IAsyncEnumerable<LdapResult<IDirectoryObject>> PagedQuery(LdapQueryParame
 
         private async Task<(bool Success, string DomainName)> ConvertDomainSidToDomainNameFromLdap(string domainSid) {
             if (!GetDomain(out var domain) || domain?.Name == null) {
+                // fix: BED-6026 adding the domainSid to _unresolvablePrincipals cache to prevent repeated resolving
+                _unresolvablePrincipals.Add(domainSid);
                 return (false, string.Empty);
             }