From b5f4fb16786cc50801615ae169211f48feee3ef5 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Mon, 29 Dec 2025 14:45:53 +0100 Subject: [PATCH 1/3] Fix typo in lupin/tdc2 --- src/spikeinterface/sorters/internal/lupin.py | 2 +- src/spikeinterface/sorters/internal/tridesclous2.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spikeinterface/sorters/internal/lupin.py b/src/spikeinterface/sorters/internal/lupin.py index 7865114f6e..ac2f67630a 100644 --- a/src/spikeinterface/sorters/internal/lupin.py +++ b/src/spikeinterface/sorters/internal/lupin.py @@ -194,7 +194,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): if apply_cmr: recording = common_reference(recording) else: - recording = apply_preprocessing_pipeline(recording, params["preprocessing_dict"]) + recording = apply_preprocessing_pipeline(recording_raw, params["preprocessing_dict"]) recording = whiten( recording, diff --git a/src/spikeinterface/sorters/internal/tridesclous2.py b/src/spikeinterface/sorters/internal/tridesclous2.py index 67fcb2e599..c32ad938d8 100644 --- a/src/spikeinterface/sorters/internal/tridesclous2.py +++ b/src/spikeinterface/sorters/internal/tridesclous2.py @@ -159,7 +159,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): if apply_cmr: recording = common_reference(recording) else: - recording = apply_preprocessing_pipeline(recording, params["preprocessing_dict"]) + recording = apply_preprocessing_pipeline(recording_raw, params["preprocessing_dict"]) if params["apply_motion_correction"]: interpolate_motion_kwargs = dict( From 32933b2cc2efcce6d47eb24890d5ce9914b67c97 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Mon, 29 Dec 2025 16:05:35 +0100 Subject: [PATCH 2/3] Add astype float32 if external preprocessing dict --- src/spikeinterface/sorters/internal/lupin.py | 1 + src/spikeinterface/sorters/internal/tridesclous2.py | 1 + 2 files changed, 2 insertions(+) diff --git a/src/spikeinterface/sorters/internal/lupin.py b/src/spikeinterface/sorters/internal/lupin.py index ac2f67630a..e09036fd8c 100644 --- a/src/spikeinterface/sorters/internal/lupin.py +++ b/src/spikeinterface/sorters/internal/lupin.py @@ -195,6 +195,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): recording = common_reference(recording) else: recording = apply_preprocessing_pipeline(recording_raw, params["preprocessing_dict"]) + recording = recording.astype("float32") recording = whiten( recording, diff --git a/src/spikeinterface/sorters/internal/tridesclous2.py b/src/spikeinterface/sorters/internal/tridesclous2.py index c32ad938d8..a4306dd431 100644 --- a/src/spikeinterface/sorters/internal/tridesclous2.py +++ b/src/spikeinterface/sorters/internal/tridesclous2.py @@ -160,6 +160,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): recording = common_reference(recording) else: recording = apply_preprocessing_pipeline(recording_raw, params["preprocessing_dict"]) + recording = recording.astype("float32") if params["apply_motion_correction"]: interpolate_motion_kwargs = dict( From b2547fc2fd3f806ec195cf02a5070b62cb18a75b Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Mon, 29 Dec 2025 21:14:28 +0100 Subject: [PATCH 3/3] Propagate job_kwargs properly to cache_preprocessing --- src/spikeinterface/sortingcomponents/tools.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/spikeinterface/sortingcomponents/tools.py b/src/spikeinterface/sortingcomponents/tools.py index 70afc17b39..3efb4e6d2e 100644 --- a/src/spikeinterface/sortingcomponents/tools.py +++ b/src/spikeinterface/sortingcomponents/tools.py @@ -429,11 +429,11 @@ def cache_preprocessing( elif mode == "folder": assert folder is not None, "cache_preprocessing(): folder must be given" - recording = recording.save_to_folder(folder=folder) + recording = recording.save_to_folder(folder=folder, **job_kwargs) cache_info["folder"] = folder elif mode == "zarr": assert folder is not None, "cache_preprocessing(): folder must be given" - recording = recording.save_to_zarr(folder=folder) + recording = recording.save_to_zarr(folder=folder, **job_kwargs) cache_info["folder"] = folder elif mode == "no-cache": recording = recording @@ -445,7 +445,7 @@ def cache_preprocessing( cache_info["mode"] = "memory" elif folder is not None: # then try folder - recording = recording.save_to_folder(folder=folder) + recording = recording.save_to_folder(folder=folder, **job_kwargs) cache_info["mode"] = "folder" cache_info["folder"] = folder else: