Skip to content

BIND preview --expect-no-changes returns error even when no change #3939

@aminvakil

Description

@aminvakil

Describe the bug
I have a domain with two providers (CLOUDFLAREAPI and BIND) and bind has been excluded by default like this:

  "bind": {
    "TYPE": "BIND",
    "directory": "zones",
    "_exclude_from_defaults": "true"
  },

Starting with dnscontrol 4.27.1 dnscontrol preview --expect-no-changes always returns non-zero code even there has not been a change.

This only gets fixed when I create a file like this touch zones/example.com.zone, it does not care if the file is empty or full as it does not get checked as expected. but starting with 4.27.1 it returns error when there is no zones/example.com.zone.

This may not be related to bind though, but this is what's happening for me.

To Reproduce
Steps to reproduce the behavior:

  1. Create a bind provider and exclude it from default, run dnscontrol preview --expect-no-changes even there is not a change.
  2. See it returns non-zero code.
  3. touch zones/example.com.zone
  4. Run again and see it does not fail anymore.

Expected behavior
Ignore bind like before because it has been excluded.

DNS Provider

  • CLOUDFLAREAPI
  • BIND

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions