Skip to content

Commit e9310a7

Browse files
authored
Fixed compilation (#187)
The thrift alias was giving this error: ``` GO111MODULE=on go test -mod=vendor ./... ? github.com/Stackdriver/stackdriver-prometheus-sidecar/bench [no test files] compilation error :go: github.com/apache/thrift@v0.12.0 used for two different module paths (git.apache.or g/thrift.git and github.com/apache/thrift) FAIL github.com/Stackdriver/stackdriver-prometheus-sidecar/cmd/stackdriver-prometheus-sidecar 0. 364s ```
1 parent 596df4c commit e9310a7

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

go.mod

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,4 @@ require (
6262
k8s.io/utils v0.0.0-20190801114015-581e00157fb1 // indirect
6363
)
6464

65-
// TODO(qingling128): Change git.apache.org to github.com/apache/thrift in
66-
// go.sum instead once all our dependencies move off git.apache.org (e.g. grep
67-
// no longer shows git.apache.org in the vendor folder).
68-
replace git.apache.org/thrift.git => github.com/apache/thrift v0.12.0
65+
go 1.13

0 commit comments

Comments
 (0)