Adopter project
lnxdrive
Adoption discussion link
#205
Finding type
Documentation gap
Charter / telemetry reference
CHARTER-01-road-to-v0-1-0-alpha-1
N-context
n/a
Description
On a multi-batch Charter where earlier phases/risks are merged to main as
they complete, straymark charter audit <ID> --prepare defaults its range to
origin/main..HEAD. For a pre-merge audit of one completed phase, the risks
already merged to main are excluded from the embedded diff, so the audit
prompt silently under-covers the phase.
Concretely, auditing Fase 1 (RISK-002 / RISK-003 / RISK-001 already merged
to main; ISSUE-002 + CI-hardening still on a branch), the default
origin/main..HEAD would have shown auditors only ISSUE-002 + CI. Covering the
whole phase required an explicit
--range <charter-declaration-commit>..HEAD (here ee710c8..HEAD) so all four
P0 risks were in the diff. The --help documents the default but not this
phase-scoped pitfall.
The dangerous part is that this is silent under-coverage — no error, no
warning. An audit prompt that quietly omits three of four risks reads as
"audited" when it is not.
Proposed upstream change
Document in the audit skill and charter audit --help that phase-scoped
audits of multi-batch Charters need an explicit --range spanning the
Charter's commits (e.g. from the Charter declaration commit), because the
default excludes already-merged phases. Optionally, when the Charter is
multi-batch (or has completed batches in the Batch Ledger), emit a notice
recommending an explicit range — or default the lower bound to the Charter's
first commit rather than origin/main.
Adopter project
lnxdrive
Adoption discussion link
#205
Finding type
Documentation gap
Charter / telemetry reference
CHARTER-01-road-to-v0-1-0-alpha-1
N-context
n/a
Description
On a multi-batch Charter where earlier phases/risks are merged to
mainasthey complete,
straymark charter audit <ID> --preparedefaults its range toorigin/main..HEAD. For a pre-merge audit of one completed phase, the risksalready merged to
mainare excluded from the embedded diff, so the auditprompt silently under-covers the phase.
Concretely, auditing Fase 1 (RISK-002 / RISK-003 / RISK-001 already merged
to
main; ISSUE-002 + CI-hardening still on a branch), the defaultorigin/main..HEADwould have shown auditors only ISSUE-002 + CI. Covering thewhole phase required an explicit
--range <charter-declaration-commit>..HEAD(hereee710c8..HEAD) so all fourP0 risks were in the diff. The
--helpdocuments the default but not thisphase-scoped pitfall.
The dangerous part is that this is silent under-coverage — no error, no
warning. An audit prompt that quietly omits three of four risks reads as
"audited" when it is not.
Proposed upstream change
Document in the audit skill and
charter audit --helpthat phase-scopedaudits of multi-batch Charters need an explicit
--rangespanning theCharter's commits (e.g. from the Charter declaration commit), because the
default excludes already-merged phases. Optionally, when the Charter is
multi-batch(or has completed batches in the Batch Ledger), emit a noticerecommending an explicit range — or default the lower bound to the Charter's
first commit rather than
origin/main.