From 95ed6824b6cf0ea7e4e63cc72a42e6eb13a7ef9d Mon Sep 17 00:00:00 2001 From: SwetAgl <91411212+SwetAgl@users.noreply.github.com> Date: Sat, 11 Jun 2022 23:29:25 +0530 Subject: [PATCH 1/2] Revert "A custom workflow" --- .github/workflows/approval-workflow.yml | 14 -------------- .github/workflows/node.js.yml | 2 +- automation.md | 7 ------- 3 files changed, 1 insertion(+), 22 deletions(-) delete mode 100644 .github/workflows/approval-workflow.yml delete mode 100644 automation.md diff --git a/.github/workflows/approval-workflow.yml b/.github/workflows/approval-workflow.yml deleted file mode 100644 index a44cf08..0000000 --- a/.github/workflows/approval-workflow.yml +++ /dev/null @@ -1,14 +0,0 @@ -name: Team awesome's approval workflow -on: pull_request_review -jobs: - labelWhenApproved: - runs-on: ubuntu-latest - steps: - - name: I like this course - uses: pullreminders/label-when-approved-action@master - env: - APPROVALS: "1" - GITHUB TOKEN: ${{ secrets.GITHUB_TOKEN }} - ADD_LABEL: "Finally Approved" - - diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index e38e407..dbe1cd6 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -41,5 +41,5 @@ jobs: run: | npm install npm test - env: + env: CI: true diff --git a/automation.md b/automation.md deleted file mode 100644 index 36255a4..0000000 --- a/automation.md +++ /dev/null @@ -1,7 +0,0 @@ -The team would like: - - [ ] branch protections - - [ ] required review approvals - - [ ] easy way to see when enough approvals has been achieved - - [ ] matrix build - - [ ] save build artifacts - - [ ] dedicated test job \ No newline at end of file From a875d2c1ea8b788981e3e92ea8f2a23d26cd824c Mon Sep 17 00:00:00 2001 From: SwetAgl <91411212+SwetAgl@users.noreply.github.com> Date: Sat, 11 Jun 2022 23:33:20 +0530 Subject: [PATCH 2/2] Update node.js.yml --- .github/workflows/node.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index dbe1cd6..e38e407 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -41,5 +41,5 @@ jobs: run: | npm install npm test - env: + env: CI: true