Skip to content

Commit 067cbbc

Browse files
authored
fix: do not pass awaitable in __get_gitlab_image_pull_secret (#1083)
Closes #1082.
1 parent 9cffdf9 commit 067cbbc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

components/renku_data_services/notebooks/core_sessions.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,12 +225,12 @@ def get_auth_secret_anonymous(nb_config: NotebooksConfig, server_name: str, requ
225225
return ExtraSecret(secret)
226226

227227

228-
def __get_gitlab_image_pull_secret(
228+
async def __get_gitlab_image_pull_secret(
229229
nb_config: NotebooksConfig, user: AuthenticatedAPIUser, image_pull_secret_name: str, access_token: str
230230
) -> ExtraSecret:
231231
"""Create a Kubernetes secret for private GitLab registry authentication."""
232232

233-
k8s_namespace = nb_config.k8s_client.namespace()
233+
k8s_namespace = await nb_config.k8s_client.namespace()
234234

235235
registry_secret = {
236236
"auths": {
@@ -605,7 +605,7 @@ async def get_image_pull_secret(
605605
):
606606
needs_pull_secret = await __requires_image_pull_secret(nb_config, image, internal_gitlab_user)
607607
if needs_pull_secret:
608-
v1_secret = __get_gitlab_image_pull_secret(
608+
v1_secret = await __get_gitlab_image_pull_secret(
609609
nb_config, user, f"{server_name}-image-secret-v1", internal_gitlab_user.access_token
610610
)
611611
return v1_secret

0 commit comments

Comments
 (0)