Skip to content

Commit ceb01c1

Browse files
olevskileafty
andauthored
fix: add default for show_project_migration_banner (#841)
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
1 parent 9d542fd commit ceb01c1

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

components/renku_data_services/migrations/versions/042eeb50cd8e_add_dismmiss_migration_banner_user_.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
def upgrade() -> None:
2020
# ### commands auto generated by Alembic - please adjust! ###
2121
op.add_column(
22-
"user_preferences", sa.Column("show_project_migration_banner", sa.Boolean(), nullable=False), schema="users"
22+
"user_preferences",
23+
sa.Column("show_project_migration_banner", sa.Boolean(), nullable=False, server_default=sa.text("true")),
24+
schema="users",
2325
)
2426
# ### end Alembic commands ###
2527

components/renku_data_services/users/orm.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from datetime import datetime
44
from typing import TYPE_CHECKING, Any, Optional
55

6-
from sqlalchemy import JSON, Boolean, DateTime, Identity, Integer, LargeBinary, MetaData, String
6+
from sqlalchemy import JSON, Boolean, DateTime, Identity, Integer, LargeBinary, MetaData, String, true
77
from sqlalchemy.dialects.postgresql import JSONB
88
from sqlalchemy.orm import DeclarativeBase, Mapped, MappedAsDataclass, mapped_column, relationship
99

@@ -79,7 +79,11 @@ class UserPreferencesORM(BaseORM):
7979
pinned_projects: Mapped[dict[str, Any]] = mapped_column("pinned_projects", JSONVariant)
8080
"""Pinned projects."""
8181

82-
show_project_migration_banner: Mapped[bool] = mapped_column("show_project_migration_banner", Boolean)
82+
show_project_migration_banner: Mapped[bool] = mapped_column(
83+
"show_project_migration_banner",
84+
Boolean,
85+
server_default=true(),
86+
)
8387
"""Show project migration banner."""
8488

8589
@classmethod

0 commit comments

Comments
 (0)