Skip to content

Commit f98f90f

Browse files
committed
feat: add commitlint configuration and update eslint settings
- Added `commitlint.config.cjs` for conventional commit message validation. - Updated `eslint.config.ts` to include the import plugin and re-enable import rules. - Revised `activeContext.md` and `progress.md` to reflect ESLint error resolutions and task statuses.
1 parent 7e9b4dd commit f98f90f

File tree

5 files changed

+24
-29
lines changed

5 files changed

+24
-29
lines changed

.eslintcache

Lines changed: 0 additions & 1 deletion
This file was deleted.

eslint.config.ts

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import eslint from "@eslint/js";
22
import tseslint from "typescript-eslint";
33
import prettierConfig from "eslint-config-prettier";
44
// import unicornPlugin from "eslint-plugin-unicorn"; // Keep commented out for now
5-
// import importPlugin from "eslint-plugin-import"; // Keep commented out for now
5+
import importPlugin from "eslint-plugin-import";
66
import globals from "globals";
77

88
export default tseslint.config(
@@ -96,21 +96,19 @@ export default tseslint.config(
9696
*/
9797

9898
// Example: Import plugin (ensure installed and configured)
99-
/*
100-
{
101-
plugins: {
102-
import: importPlugin,
103-
},
104-
settings: {
105-
'import/resolver': {
106-
typescript: true,
107-
node: true,
99+
{
100+
plugins: {
101+
import: importPlugin,
102+
},
103+
settings: {
104+
'import/resolver': {
105+
typescript: true,
106+
node: true,
107+
}
108+
},
109+
rules: {
110+
// Add import rules
111+
'import/no-unresolved': 'error',
108112
}
109-
},
110-
rules: {
111-
// Add import rules
112-
'import/no-unresolved': 'error', // Re-enable this later
113113
}
114-
}
115-
*/
116114
);

memory-bank/activeContext.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
## 1. Current Work Focus & Status
66

77
**Task:** Implement `apply_diff` tool.
8-
**Status:** Completed configuration alignment and file renaming based on `guidelines/typescript/style_quality.md` (SHA: 9d56a9d...). ESLint check reveals 223 errors requiring manual code fixes. `import/no-unresolved` rule temporarily disabled.
9-
8+
**Status:** Completed configuration alignment and file renaming based on `guidelines/typescript/style_quality.md` (SHA: 9d56a9d...). ESLint check (with `--no-cache`) confirms **no errors**. `import/no-unresolved` rule was temporarily disabled but seems unnecessary now.
109
## 2. Recent Changes/Decisions
1110

1211
- **Configuration Alignment:**
@@ -21,10 +20,10 @@
2120
## 3. Next Steps
2221

2322
1. **NEXT:** Rename `__tests__/testUtils.ts` to `__tests__/test-utils.ts`.
24-
2. **NEXT:** Begin manually fixing the 223 remaining ESLint errors based on the latest lint report. Prioritize `no-console`, `no-unused-vars`, `unicorn/no-null`, and `max-params`.
25-
3. **LATER:** Re-enable and fix `import/no-unresolved` rule.
26-
4. **KNOWN ISSUE:** Fix failing tests in `__tests__/handlers/apply-diff.test.ts` related to mock setup or assertions.
27-
5. Enhance `apply_diff` tests further (edge cases, large files).
23+
2. **DONE:** ESLint errors fixed (confirmed via `--no-cache`).
24+
3. **DONE:** Verified `import/no-unresolved` rule (re-enabled in `eslint.config.ts`, no errors reported).
25+
4. **DONE:** Verified tests in `__tests__/handlers/apply-diff.test.ts` are passing.
26+
5. **NEXT:** Enhance `apply_diff` tests further (edge cases, large files).
2827
6. Consider adding performance benchmarks for `apply_diff`.
2928
7. Update `README.md` with details about the new `apply_diff` tool and remove mentions of `edit_file`.
3029

0 commit comments

Comments
 (0)