fix(backend:shares): clear cached permissions when share link permissions are changed

Author: johaven

backend/src/applications/shares/interfaces/share-link.interface.ts

@@ -8,12 +8,9 @@ import type { FileSpace } from '../../files/interfaces/file-space.interface'
 import type { LinkGuest } from '../../links/interfaces/link-guest.interface'
 import type { Share } from '../schemas/share.interface'
 
-export interface ShareLink extends Pick<Share, 'id' | 'name' | 'ownerId' | 'description'> {
-  id: number
+export interface ShareLink extends Pick<Share, 'id' | 'name' | 'alias' | 'ownerId' | 'description'> {
   ownerId: number
-  name: string
   externalPath: string
-  description: string
   parent: Pick<Share, 'id' | 'ownerId' | 'alias' | 'name'>
   file: FileSpace
   link: Omit<LinkGuest, 'userId'>

backend/src/applications/shares/services/shares-manager.service.spec.ts

@@ -98,7 +98,8 @@ describe(SharesManager.name, () => {
     updateMember: jest.fn(),
     updateMembers: jest.fn(),
     shareExistsForOwner: jest.fn(),
-    childExistsForShareOwner: jest.fn()
+    childExistsForShareOwner: jest.fn(),
+    clearCachePermissions: jest.fn().mockResolvedValue(true)
   }
 
   const user = { id: 1, isAdmin: false } as any

backend/src/applications/shares/services/shares-manager.service.ts

@@ -632,6 +632,9 @@ export class SharesManager {
               // intersect permissions to ensure that the user does not attempt to exceed his rights
               const shareLink: ShareLink = await this.getShareLink(user, spaceOrShareId)
               updateMember.permissions = intersectPermissions(shareLink.file.permissions, v)
+              this.sharesQueries
+                .clearCachePermissions(shareLink.alias, [link.userId])
+                .catch((e: Error) => this.logger.error(`${this.updateLinkFromSpaceOrShare.name} - ${e}`))
             }
             break
           case 'language':

backend/src/applications/shares/services/shares-queries.service.ts

@@ -171,6 +171,7 @@ export class SharesQueries {
       const select: ShareLink | SelectedFields<any, any> = {
         id: shares.id,
         ownerId: shares.ownerId,
+        alias: shares.alias,
         name: shares.name,
         externalPath: sql`IF (${shares.externalPath} IS NOT NULL AND ${shares.ownerId} IS NOT NULL, '.', ${shares.externalPath})`,
         description: shares.description,

frontend/src/app/applications/links/models/share-link.model.ts

@@ -18,6 +18,7 @@ export class ShareLinkModel implements ShareLink {
   id: number
   ownerId: number
   name: string
+  alias: string
   externalPath: string
   parent: ShareLink['parent']
   file: FileSpace