Skip to content

Commit bbc4c80

Browse files
committed
[TASK] Avoid value decoding in DataSet::import()
TYPO3 v14 no longer converts values to database values when using `Connection::insert()`, which makes decoding values from CSV DataSet files an error. One solution would be to pass the argument to enforce converting values again, which is used here. This is possible since an early introduction of the method argument with [1] and becomes mandantory with [2] flipping the default value. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/89293 [2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/90957 Releases: main
1 parent c0c7bf9 commit bbc4c80

File tree

1 file changed

+2
-2
lines changed
  • Classes/Core/Functional/Framework/DataHandling

1 file changed

+2
-2
lines changed

Classes/Core/Functional/Framework/DataHandling/DataSet.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,14 @@ public static function import(string $path): void
8585
$types[] = $columnType->getBindingType();
8686
}
8787
// Insert the row
88-
$connection->insert($tableName, $element, $types);
88+
$connection->insert($tableName, $element, $types, true);
8989
}
9090
Testbase::resetTableSequences($connection, $tableName);
9191
}
9292
}
9393

9494
/**
95-
* Main entry method: Get at absosulete (!) path to a .csv file, read it and return an instance of self
95+
* Main entry method: Get at absolute (!) path to a .csv file, read it and return an instance of self
9696
*/
9797
public static function read(string $fileName, bool $applyDefaultValues = false, bool $checkForDuplicates = false): self
9898
{

0 commit comments

Comments
 (0)