feat: use ListCollector to build lists

Author: Tarmil

benchmarks/FSharp.SystemTextJson.Benchmarks/Program.fs

@@ -6,23 +6,18 @@ open System
 open BenchmarkDotNet.Attributes
 open BenchmarkDotNet.Diagnosers
 open BenchmarkDotNet.Configs
-open BenchmarkDotNet.Jobs
 open BenchmarkDotNet.Running
 open BenchmarkDotNet.Validators
 open BenchmarkDotNet.Exporters
-open BenchmarkDotNet.Environments
-open System.Reflection
-open BenchmarkDotNet.Configs
 
 open System.Text.Json
 open System.Text.Json.Serialization
 open Newtonsoft.Json
-open Newtonsoft.Json.Linq
 
 type TestRecord =
     { name: string
       thing: bool option
-      time: System.DateTimeOffset }
+      time: DateTimeOffset }
 
 type SimpleClass() =
     member val Name: string = null with get, set
@@ -94,6 +89,28 @@ type ReflectionComparison() =
         for i in 0 .. this.Iterations do
             TypeCache.isRecord typeof<TestRecord> |> ignore
 
+type ListDeserialization<'t>(instance: 't) =
+    let options = JsonFSharpOptions().ToJsonSerializerOptions()
+
+    [<Params(10, 100)>]
+    member val ListLength = 0 with get, set
+
+    member val String = "" with get, set
+
+    [<GlobalSetup>]
+    member this.InitList() =
+        this.String <- System.Text.Json.JsonSerializer.Serialize(Array.replicate this.ListLength instance, options)
+
+    [<Benchmark>]
+    member this.ListCollector() =
+        System.Text.Json.JsonSerializer.Deserialize<'t list>(this.String, options)
+
+    [<Benchmark>]
+    member this.AsArray() =
+        System.Text.Json.JsonSerializer.Deserialize<'t array>(this.String, options)
+        |> List.ofArray
+
+type ListDeserialization() = inherit ListDeserialization<int>(42)
 
 let config =
     ManualConfig
@@ -106,7 +123,8 @@ let defaultSwitch () =
     BenchmarkSwitcher(
         [| typeof<Records>
            typeof<Classes>
-           typeof<ReflectionComparison> |]
+           typeof<ReflectionComparison>
+           typeof<ListDeserialization> |]
     )
 
 

paket.dependencies

@@ -2,7 +2,7 @@ frameworks netstandard2.0
 storage none
 source https://api.nuget.org/v3/index.json
 
-nuget FSharp.Core >= 4.7.0 lowest_matching:true
+nuget FSharp.Core >= 6.0 lowest_matching:true
 nuget Microsoft.SourceLink.GitHub prerelease copy_local:true
 nuget Nerdbank.GitVersioning copy_local:true
 nuget System.Text.Json >= 6.0.10 lowest_matching: true
@@ -12,7 +12,7 @@ framework net9.0
 storage none
 source https://api.nuget.org/v3/index.json
 
-nuget FSharp.Core >= 5.0
+nuget FSharp.Core >= 6.0
 nuget FsCheck.XUnit
 nuget Microsoft.NET.Test.Sdk
 nuget System.Text.Json >= 8.0.5 prerelease