Skip to content

docs(contributing): fix incorrect vector iteration and simplify quick_sort example #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aditya-354 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs(contributing): fix incorrect vector iteration and simplify quick_sort example #3071

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43aab0d
Fixed overcomplicated quick_sort test range in CONTRIBUTING.md
Aditya-354 Dec 5, 2025
c2c830c
Replace incorrect sizeof-based loop with arr.size() in CONTRIBUTING.m…
Aditya-354 Dec 5, 2025
a3803f1
Replace incorrect sizeof-based loop with modern range-based loop in C…
Aditya-354 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ You can add new algorithms or data structures that are **not present in the repo
// Let's make sure the array of numbers is ordered after calling the function.
std::vector<uint64_t> arr = {5, 3, 8, 12, 14, 16, 28, 96, 2, 5977};
std::vector<uint64_t> arr_sorted = sorting::quick_sort::quick_sort(
arr, 0, int(std::end(arr) - std::begin(arr)) - 1);
arr, 0, arr.size() - 1);

assert(std::is_sorted(std::begin(arr_sorted), std::end(arr_sorted)));
```
Expand Down Expand Up @@ -97,8 +97,8 @@ assert(backtracking::subset_sum::number_of_subsets(0, array1) ==
*/
template <typename T>
bool is_number_on_array(const std::vector<T> &arr, const int &number) {
for (int i = 0; i < sizeof(arr) / sizeof(int); i++) {
if (arr[i] == number) {
for (const auto &x : arr) {
if (x == number) {
return true;
}
else {
Expand Down