Skip to content

Commit 2e0837b

Browse files
authored
fix: update and fix ci-info import for detecting CI (electron-userland#9356)
1 parent b741b72 commit 2e0837b

4 files changed

Lines changed: 16 additions & 5 deletions

File tree

.changeset/stupid-towns-shout.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix: fix ci-info import for detecting CI

packages/app-builder-lib/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"builder-util": "workspace:*",
6161
"builder-util-runtime": "workspace:*",
6262
"chromium-pickle-js": "^0.2.0",
63-
"ci-info": "^4.2.0",
63+
"ci-info": "4.3.1",
6464
"debug": "^4.3.4",
6565
"dotenv": "^16.4.5",
6666
"dotenv-expand": "^11.0.6",

packages/app-builder-lib/src/publish/PublishManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {
3131
} from "electron-publish"
3232
import { MultiProgress } from "electron-publish/out/multiProgress"
3333
import { writeFile } from "fs/promises"
34-
import * as isCi from "ci-info"
34+
import { isCI } from "ci-info"
3535
import * as path from "path"
3636
import { WriteStream as TtyWriteStream } from "tty"
3737
import * as url from "url"
@@ -91,7 +91,7 @@ export class PublishManager implements PublishContext {
9191
if (tag != null) {
9292
log.info({ reason: "tag is defined", tag }, "artifacts will be published")
9393
publishOptions.publish = "onTag"
94-
} else if (isCi) {
94+
} else if (isCI) {
9595
log.info({ reason: "CI detected" }, "artifacts will be published if draft release exists")
9696
publishOptions.publish = "onTagOrDraft"
9797
}

pnpm-lock.yaml

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)