Fix: warn on dbt variable definition failure instead of raising (#5427)

Author: georgesittas

sqlmesh/dbt/context.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import logging
 import typing as t
 from dataclasses import dataclass, field, replace
 from pathlib import Path
@@ -28,6 +29,8 @@
     from sqlmesh.dbt.seed import SeedConfig
     from sqlmesh.dbt.source import SourceConfig
 
+logger = logging.getLogger(__name__)
+
 
 @dataclass
 class DbtContext:
@@ -125,7 +128,7 @@ def _var(name: str, default: t.Optional[t.Any] = None) -> t.Any:
             try:
                 rendered_variables[k] = _render_var(v)
             except Exception as ex:
-                raise ConfigError(f"Failed to render variable '{k}', value '{v}': {ex}") from ex
+                logger.warning(f"Failed to render variable '{k}', value '{v}': {ex}")
 
         self.variables = rendered_variables
 

tests/dbt/test_config.py

@@ -352,6 +352,7 @@ def test_variables(assert_exp_eq, sushi_test_project):
             "some_var": ["foo", "bar"],
         },
         "some_var": "should be overridden in customers package",
+        "invalid_var": "{{ ref('ref_without_closing_paren' }}",
     }
     expected_customer_variables = {
         "some_var": ["foo", "bar"],  # Takes precedence over the root project variable
@@ -370,6 +371,7 @@ def test_variables(assert_exp_eq, sushi_test_project):
             {"name": "item1", "value": 1},
             {"name": "item2", "value": 2},
         ],
+        "invalid_var": "{{ ref('ref_without_closing_paren' }}",
     }
     assert sushi_test_project.packages["sushi"].variables == expected_sushi_variables
     assert sushi_test_project.packages["customers"].variables == expected_customer_variables

tests/fixtures/dbt/sushi_test/dbt_project.yml

@@ -66,6 +66,9 @@ vars:
     - name: 'item2'
       value: 2
 
+  # Despite this being an invalid variable definition, dbt doesn't mind if it's unused
+  invalid_var: "{{ ref('ref_without_closing_paren' }}"
+
 
 on-run-start:
   - 'CREATE TABLE IF NOT EXISTS analytic_stats (physical_table VARCHAR, evaluation_time VARCHAR);'