From 67b3ee06f0f536c197e6a04d5abc2c95bd628f3a Mon Sep 17 00:00:00 2001 From: "Markus J. Ankenbrand" Date: Mon, 24 Nov 2025 15:56:28 +0100 Subject: [PATCH 1/2] Add test for min_constraint --- tests/transforms/test_transforms.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/transforms/test_transforms.py b/tests/transforms/test_transforms.py index be99c185..a8d55918 100644 --- a/tests/transforms/test_transforms.py +++ b/tests/transforms/test_transforms.py @@ -253,6 +253,10 @@ def test_arguments_are_and_are_not_dict(self): with pytest.raises(ValueError): transform.arguments_are_dict() + def test_min_constraint(self): + transform = tio.RandomNoise() + assert transform._parse_range(3, 'name', min_constraint=0) == (0,3) + def test_bad_over_max(self): transform = tio.RandomNoise() with pytest.raises(ValueError): From a3a0f8705d6d968a63d7a4d912bab9565f8b9c1c Mon Sep 17 00:00:00 2001 From: "Markus J. Ankenbrand" Date: Mon, 24 Nov 2025 15:56:54 +0100 Subject: [PATCH 2/2] Fix min_constraint bug in _parse_range Resolve #1389 --- src/torchio/transforms/transform.py | 2 +- tests/transforms/test_transforms.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/torchio/transforms/transform.py b/src/torchio/transforms/transform.py index 93b4f8f7..2375e7ce 100644 --- a/src/torchio/transforms/transform.py +++ b/src/torchio/transforms/transform.py @@ -331,7 +331,7 @@ def _parse_range( f'If {name} is a single number, it must be of' f' type {type_constraint}, not {nums_range}', ) - min_range = -nums_range if min_constraint is None else nums_range + min_range = -nums_range if min_constraint is None else min_constraint return (min_range, nums_range) try: diff --git a/tests/transforms/test_transforms.py b/tests/transforms/test_transforms.py index a8d55918..07b6c346 100644 --- a/tests/transforms/test_transforms.py +++ b/tests/transforms/test_transforms.py @@ -255,7 +255,7 @@ def test_arguments_are_and_are_not_dict(self): def test_min_constraint(self): transform = tio.RandomNoise() - assert transform._parse_range(3, 'name', min_constraint=0) == (0,3) + assert transform._parse_range(3, 'name', min_constraint=0) == (0, 3) def test_bad_over_max(self): transform = tio.RandomNoise()