From 203469e07d7b398e365b031d77ac2cfa3ba07926 Mon Sep 17 00:00:00 2001 From: TurtleWolfe Date: Sat, 4 Jul 2026 17:33:53 +0000 Subject: [PATCH] =?UTF-8?q?fix(ci):=20#168=20drop=20lighthouse:no-pwa=20pr?= =?UTF-8?q?eset=20=E2=80=94=20it=20re-failed=20every=20main=20push?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Follow-up to #172. Removing continue-on-error correctly surfaced a real problem: the post-merge lighthouse job failed on 82a69ea — but NOT at collect (the #172 URL fix worked, collect ran clean against all 3 URLs). It failed at ASSERT: the `lighthouse:no-pwa` preset ships error-level per-audit assertions (errors-in-console, valid-source-maps, legacy-javascript, forced-reflow-insight, ...) that fail on a perfectly healthy site — re-creating the exact "red check everyone ignores" this issue set out to kill. This monitor is a daily/push perf DASHBOARD (commits scores to docs/lighthouse-scores.json, runs on schedule + push-to-main), not a merge gate. So: drop the preset, keep only the four warn-level category assertions. Score regressions now surface as warnings in the log without failing the job; a genuine collect failure (site unreachable) still fails loudly because the step is no longer continue-on-error. Verified locally: `lhci assert --config=.github/lighthouse/lighthouserc.json` against the live site → exit 0, zero error-level failures (was six ✘ on the 82a69ea run). Refs #168 Co-Authored-By: Claude Fable 5 --- .github/lighthouse/lighthouserc.json | 2 +- .gitignore | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/lighthouse/lighthouserc.json b/.github/lighthouse/lighthouserc.json index f99ccec1..e2768778 100644 --- a/.github/lighthouse/lighthouserc.json +++ b/.github/lighthouse/lighthouserc.json @@ -27,7 +27,7 @@ } }, "assert": { - "preset": "lighthouse:no-pwa", + "// note": "No preset — this is a daily/push perf DASHBOARD, not a merge gate (the job commits scores to docs/lighthouse-scores.json and runs on schedule + push-to-main). The lighthouse:no-pwa preset ships error-level per-audit assertions (errors-in-console, valid-source-maps, legacy-javascript...) that would fail every main push on a healthy site — the exact 'red check everyone ignores' problem #168 fixed. Category scores are warn-level: regressions show in the logs without failing the job. A genuine collect failure (site unreachable) still fails loudly because the step is no longer continue-on-error.", "assertions": { "categories:performance": ["warn", { "minScore": 0.5 }], "categories:accessibility": ["warn", { "minScore": 0.8 }], diff --git a/.gitignore b/.gitignore index 9885a934..fa041bf2 100644 --- a/.gitignore +++ b/.gitignore @@ -138,3 +138,4 @@ scripts/__tests__/fixtures/* # SpecKit wrapper (Docker-first) — tool + cache state, never commit .speckit-tools/ .speckit-cache/ +.lighthouseci/