Fix running analysis view and update model options

Refactored UnifiedAnalysisHistory to pass the full analysis object to viewRunningAnalysis, ensuring correct selection of analysis ID and ticker. Also removed an invalid 'gpt-5' entry from OpenAI model options in Settings, and cleaned up whitespace in provider and trading settings reset functions.

Author: BWJ2310

src/components/UnifiedAnalysisHistory.tsx

@@ -479,10 +479,10 @@ export default function UnifiedAnalysisHistory() {
     }
   };
 
-  const viewRunningAnalysis = (ticker: string) => {
-    setSelectedTicker(ticker);
+  const viewRunningAnalysis = (analysis: RunningAnalysisItem) => {
+    setSelectedTicker(analysis.ticker);
+    setSelectedViewAnalysisId(analysis.id);
     setSelectedAnalysisDate(null);
-    setSelectedViewAnalysisId(null);
   };
 
   const viewDetails = (analysis: AnalysisHistoryItem) => {
@@ -1032,7 +1032,7 @@ export default function UnifiedAnalysisHistory() {
                       <div
                         key={item.id}
                         className="border border-border rounded-lg p-4 space-y-3 cursor-pointer hover:bg-muted/50 transition-colors"
-                        onClick={() => viewRunningAnalysis(item.ticker)}
+                        onClick={() => viewRunningAnalysis(item)}
                       >
                         <div className="flex items-center justify-between">
                           <div className="flex items-center gap-3">
@@ -1093,7 +1093,7 @@ export default function UnifiedAnalysisHistory() {
                               className="border border-slate-700"
                               onClick={(e) => {
                                 e.stopPropagation();
-                                viewRunningAnalysis(item.ticker);
+                                viewRunningAnalysis(item);
                               }}
                             >
                               <Eye className="h-4 w-4 mr-1" />
@@ -1302,7 +1302,7 @@ export default function UnifiedAnalysisHistory() {
                     <div
                       key={item.id}
                       className="border border-border rounded-lg p-4 space-y-3 cursor-pointer hover:bg-muted/50 transition-colors"
-                      onClick={() => viewRunningAnalysis(item.ticker)}
+                      onClick={() => viewRunningAnalysis(item)}
                     >
                       <div className="flex items-center justify-between">
                         <div className="flex items-center gap-3">
@@ -1357,14 +1357,14 @@ export default function UnifiedAnalysisHistory() {
                           )}
                         </div>
                         <div className="flex items-center gap-2">
-                          <Button
-                            size="sm"
-                            variant="ghost"
-                            className="border border-slate-700"
-                            onClick={(e) => {
-                              e.stopPropagation();
-                              viewRunningAnalysis(item.ticker);
-                            }}
+                            <Button
+                              size="sm"
+                              variant="ghost"
+                              className="border border-slate-700"
+                              onClick={(e) => {
+                                e.stopPropagation();
+                                viewRunningAnalysis(item);
+                              }}
                           >
                             <Eye className="h-4 w-4 mr-1" />
                             View Details

src/pages/Settings.tsx

@@ -895,7 +895,7 @@ export default function SettingsPage() {
   const getModelOptions = (provider: string) => {
     switch (provider) {
       case 'openai':
-        return ['	gpt-5', 'gpt-5-mini', 'gpt-5-nano', 'gpt-4.1', 'gpt-4.1-mini', 'gpt-4o', 'custom'];
+        return ['gpt-4.1', 'gpt-4.1-mini', 'gpt-4o', 'custom'];
       case 'anthropic':
         return ['claude-opus-4-1-20250805', 'claude-opus-4-20250514', 'claude-sonnet-4-20250514', 'claude-3-7-sonnet-20250219', 'claude-3-5-haiku-20241022', 'custom'];
       case 'google':
@@ -996,10 +996,10 @@ export default function SettingsPage() {
   // Clear all provider settings
   const handleClearProviders = async () => {
     if (!user?.id) return;
-    
+
     try {
       setSavingTab('providers');
-      
+
       // Clear all provider settings - only set fields that exist in api_settings table
       const clearedSettings = {
         ai_provider: 'openrouter', // Keep a default provider to satisfy required field
@@ -1030,16 +1030,16 @@ export default function SettingsPage() {
       setAiProviders([{ id: '1', nickname: 'Default AI', provider: 'openrouter', apiKey: '' }]);
       setDefaultAiModel('gpt-4');
       setDefaultCustomModel('');
-      
+
       // Reload settings from backend to refresh auth context
       await checkConfiguredProviders();
       await loadProviderConfigurations();
-      
+
       toast({
         title: "Provider settings cleared",
         description: "All provider API keys have been removed.",
       });
-      
+
     } catch (error) {
       console.error('Error clearing provider settings:', error);
       toast({
@@ -1055,10 +1055,10 @@ export default function SettingsPage() {
   // Clear all trading settings
   const handleClearTrading = async () => {
     if (!user?.id) return;
-    
+
     try {
       setSavingTab('trading');
-      
+
       // Clear all trading settings - use empty strings for API keys
       const clearedSettings = {
         alpaca_paper_api_key: '',
@@ -1097,16 +1097,16 @@ export default function SettingsPage() {
       setProfitTarget(25);
       setStopLoss(10);
       setNearLimitThreshold(20);
-      
+
       // Reload settings from backend to refresh auth context
       await checkConfiguredProviders();
       await loadMaskedTradingCredentials();
-      
+
       toast({
         title: "Trading settings cleared",
         description: "All Alpaca credentials have been removed and settings reset to defaults.",
       });
-      
+
     } catch (error) {
       console.error('Error clearing trading settings:', error);
       toast({