Improve error handling for order execution failures

Introduces a reusable extractErrorMessage utility to provide more informative error messages in toasts when order execution fails. Updates RecentTrades, TradeHistoryTable, and useOrderActions to use this function for both API and exception errors. Also updates Header to refresh running analyses count on route changes and corrects the interval timing.

Author: BWJ2310

src/components/Header.tsx

@@ -1,4 +1,4 @@
-import { Link, useNavigate } from "react-router-dom";
+import { Link, useNavigate, useLocation } from "react-router-dom";
 import { useState, useEffect, useMemo } from "react";
 import { Button } from "@/components/ui/button";
 import {
@@ -36,6 +36,7 @@ import {
 
 export default function Header() {
   const navigate = useNavigate();
+  const location = useLocation();
   const { user, profile, isAuthenticated, logout, apiSettings } = useAuth();
   const { getPrimaryRole, isLoading: isRoleLoading } = useRBAC();
   const [runningAnalyses, setRunningAnalyses] = useState(0);
@@ -112,10 +113,10 @@ export default function Header() {
     };
 
     checkRunningTasks();
-    const interval = setInterval(checkRunningTasks, 10000); // Check every 10 seconds
+    const interval = setInterval(checkRunningTasks, 100000); // Check every 10 seconds
 
     return () => clearInterval(interval);
-  }, [user]);
+  }, [user, location.pathname]);
 
   return (
     <div className="sticky top-0 z-50">

src/components/RecentTrades.tsx

@@ -36,6 +36,38 @@ interface TradeDecision {
   createdAt: string;
 }
 
+const extractErrorMessage = (value: unknown): string | null => {
+  if (!value) return null;
+
+  if (typeof value === 'string') {
+    return value;
+  }
+
+  if (value instanceof Error) {
+    return value.message;
+  }
+
+  if (typeof value === 'object') {
+    const record = value as Record<string, unknown>;
+    const candidateKeys = ['errorDetail', 'error', 'message', 'warning', 'details', 'reason'] as const;
+
+    for (const key of candidateKeys) {
+      const nested = record[key];
+      if (!nested || nested === value) continue;
+      const extracted = extractErrorMessage(nested);
+      if (extracted) {
+        return extracted;
+      }
+    }
+
+    if (record.code !== undefined) {
+      return String(record.code);
+    }
+  }
+
+  return null;
+};
+
 function RecentTrades() {
   const [loading, setLoading] = useState(true);
   const [allTrades, setAllTrades] = useState<TradeDecision[]>([]);
@@ -356,17 +388,18 @@ function RecentTrades() {
         // Refresh trades
         fetchAllTrades();
       } else {
+        const errorDescription = extractErrorMessage(data) || "Failed to execute order";
         toast({
           title: "Order Failed",
-          description: data.message || "Failed to execute order",
+          description: errorDescription,
           variant: "destructive",
         });
       }
     } catch (err: any) {
       console.error('Error executing order:', err);
       toast({
         title: "Order Failed",
-        description: err.message || 'Failed to execute order on Alpaca',
+        description: extractErrorMessage(err) || 'Failed to execute order on Alpaca',
         variant: "destructive"
       });
     } finally {

src/components/TradeHistoryTable.tsx

@@ -45,6 +45,38 @@ interface RebalanceGroup {
   trades: TradeDecision[];
 }
 
+const extractErrorMessage = (value: unknown): string | null => {
+  if (!value) return null;
+
+  if (typeof value === 'string') {
+    return value;
+  }
+
+  if (value instanceof Error) {
+    return value.message;
+  }
+
+  if (typeof value === 'object') {
+    const record = value as Record<string, unknown>;
+    const candidateKeys = ['errorDetail', 'error', 'message', 'warning', 'details', 'reason'] as const;
+
+    for (const key of candidateKeys) {
+      const nested = record[key];
+      if (!nested || nested === value) continue;
+      const extracted = extractErrorMessage(nested);
+      if (extracted) {
+        return extracted;
+      }
+    }
+
+    if (record.code !== undefined) {
+      return String(record.code);
+    }
+  }
+
+  return null;
+};
+
 export default function TradeHistoryTable() {
   const [loading, setLoading] = useState(true);
   const [refreshing, setRefreshing] = useState(false); // Separate state for refresh button
@@ -429,17 +461,18 @@ export default function TradeHistoryTable() {
         // Refresh trades
         fetchAllTrades(false);
       } else {
+        const errorDescription = extractErrorMessage(data) || "Failed to execute order";
         toast({
           title: "Order Failed",
-          description: data.message || "Failed to execute order",
+          description: errorDescription,
           variant: "destructive",
         });
       }
     } catch (err: any) {
       console.error('Error executing order:', err);
       toast({
         title: "Order Failed",
-        description: err.message || 'Failed to execute order on Alpaca',
+        description: extractErrorMessage(err) || 'Failed to execute order on Alpaca',
         variant: "destructive"
       });
     } finally {

src/components/analysis-detail/hooks/useOrderActions.ts

@@ -17,6 +17,38 @@ interface UseOrderActionsProps {
   updateAnalysisData: (updates: Partial<any>) => void;
 }
 
+const extractErrorMessage = (value: unknown): string | null => {
+  if (!value) return null;
+
+  if (typeof value === 'string') {
+    return value;
+  }
+
+  if (value instanceof Error) {
+    return value.message;
+  }
+
+  if (typeof value === 'object') {
+    const record = value as Record<string, unknown>;
+    const candidateKeys = ['errorDetail', 'error', 'message', 'warning', 'details', 'reason'] as const;
+
+    for (const key of candidateKeys) {
+      const nested = record[key];
+      if (!nested || nested === value) continue;
+      const extracted = extractErrorMessage(nested);
+      if (extracted) {
+        return extracted;
+      }
+    }
+
+    if (record.code !== undefined) {
+      return String(record.code);
+    }
+  }
+
+  return null;
+};
+
 export function useOrderActions({ analysisData, updateAnalysisData }: UseOrderActionsProps) {
   const { user } = useAuth();
   const { toast } = useToast();
@@ -157,9 +189,10 @@ export function useOrderActions({ analysisData, updateAnalysisData }: UseOrderAc
           pollAlpacaOrderStatus(data.alpacaOrderId);
         }
       } else {
+        const errorDescription = extractErrorMessage(data) || "Failed to execute order";
         toast({
           title: "Order Failed",
-          description: data.message || "Failed to execute order",
+          description: errorDescription,
           variant: "destructive",
         });
       }
@@ -173,7 +206,7 @@ export function useOrderActions({ analysisData, updateAnalysisData }: UseOrderAc
       });
       toast({
         title: "Order Failed",
-        description: error.message || "Failed to execute order on Alpaca",
+        description: extractErrorMessage(error) || "Failed to execute order on Alpaca",
         variant: "destructive",
       });
     } finally {
@@ -244,7 +277,7 @@ export function useOrderActions({ analysisData, updateAnalysisData }: UseOrderAc
       });
       toast({
         title: "Error",
-        description: error.message || "Failed to reject order",
+        description: extractErrorMessage(error) || "Failed to reject order",
         variant: "destructive",
       });
     } finally {