Energy window threshold for root

[ludovicabrusaferri]

In "InputStreamFromROOTFIle.cxx":
this->parser.add_key("low energy window (keV)", &this->low_energy_window);
this->parser.add_key("upper energy window (keV)", &this->up_energy_window);

The the energy thresholds are given in keV. However, gate energies are stored in MeV. Either the energy or the energy window threshold need to be rescaled.
Currently this doesn't create any problem as the threshold values are set respectively to 0 and 1000.

[KrisThielemans]

Good spot. I prefer to rescale the energies when reading from ROOT. That way, STIR remains in keV Kris

…

________________________________ From: ludovicabrusaferri <notifications@github.com> Sent: Monday, August 5, 2019 4:45:32 PM To: UCL/STIR <STIR@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [UCL/STIR] Energy window threshold for root (#356) In "InputStreamFromROOTFIle.cxx": this->parser.add_key("low energy window (keV)", &this->low_energy_window); this->parser.add_key("upper energy window (keV)", &this->up_energy_window); The the energy thresholds are given in keV. However, gate energies are stored in MeV. Either rescaling the energy or the energy window threshold need to be rescaled. Currently this doesn't create any problem as the threshold values are set respectively to 0 and 1000. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#356?email_source=notifications&email_token=ABQRIHLN33CIXU53AKUMV6DQDBDJZA5CNFSM4IJMRNL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDNNDKA>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQRIHLTSCUTHYAFFQLKBCTQDBDJZANCNFSM4IJMRNLQ>.

[robbietuk]

This can be closed as it was fixed with #736