Crop module overestimates crop losses

[sebastianrowan]

crop.Compute does not account for the resolution of the crop data raster and therefore treats each cell as having an area of 1 acre. The default CDL files have a 30m resolution and there is a version available with 10m resolution.

Potential solution: Check raster cell size and units and calculate scaling factor to convert losses per acre to losses per cell.

[HenryGeorgist]

go-consequences/crops/crop.go

Line 12 in 38c43dd

type Crop struct {

i propose we add a float64 of "Acres" to the crop definition defaulting to .22.
add a "WithAcres" method to the builder pattern

i propose we calculate acres provided per cell on the

go-consequences/cropprovider/nass-geotif-reader.go

Line 12 in 38c43dd

type nassTiffReader struct {

it needs to be fetched somehow from the gdal dataset then when a crop is generated the acres needs to be set:

go-consequences/cropprovider/nass-streamprovider.go

Line 67 in 38c43dd

c.WithLocation(xval, yval)

after the location is set set the WithAcres based on the tiff reader's acres.

go-consequences/crops/crop.go

Line 150 in 38c43dd

results[4] = damage

on this line in the crop set the damage to be damage*c.Acres so that all damage results are scaled to the area represeented by the generated crop cell.