-
-
Notifications
You must be signed in to change notification settings - Fork 75
fix(checkout): commit JS validation fix for auto-generate-password forms #741
Copy link
Copy link
Closed
Labels
auto-dispatchbugSomething isn't workingSomething isn't workingstatus:in-progressWork is in progressWork is in progress
Description
Problem
After PR #737 (simple checkout form template) merged, inc/checkout/class-checkout.php has an uncommitted fix sitting on main.
The fix adds form_has_auto_generate_password() method and uses it in get_js_validation_rules() to strip password-related JS validation rules when the checkout form uses auto-generated passwords. Without this, the JS validator requires a password field that is never rendered, blocking form submission.
What to do
- Create a worktree from
main - Implement the fix: add
form_has_auto_generate_password(): boolprotected method that iterates form settings to detect password fields withauto_generate_passwordenabled - In
get_js_validation_rules(), call this method andunset($raw_rules['password'], $raw_rules['password_conf'], $raw_rules['valid_password'])when true - Commit and open a PR
Branch feature/738-simple-checkout-followup-fixes on origin has a similar implementation for reference.
Acceptance Criteria
-
form_has_auto_generate_password()method exists inCheckoutclass -
get_js_validation_rules()strips password rules when auto-generate is enabled - PR passes CI
aidevops.sh v3.5.718 plugin for OpenCode v1.3.0 with claude-sonnet-4-6 spent 6m and 11,460 tokens on this as a headless worker.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
auto-dispatchbugSomething isn't workingSomething isn't workingstatus:in-progressWork is in progressWork is in progress