Feature remove port dependancy

Author: Mishhub

README.md

@@ -74,12 +74,11 @@ Create a `config/minio.config.ts` file:
 import { registerAs } from '@nestjs/config';
 
 export default registerAs('minio', () => ({
-  endPoint: process.env.MINIO_ENDPOINT || 'localhost',
+  endPoint: process.env.MINIO_ENDPOINT || 'localhost:9000', // Format: "host" or "host:port"
   externalEndPoint:
     process.env.MINIO_EXTERNAL_ENDPOINT ||
     process.env.MINIO_ENDPOINT ||
-    'localhost',
-  port: parseInt(process.env.MINIO_PORT || '9000', 10),
+    'localhost:9000', // Format: "host" or "host:port"
   useSSL: process.env.MINIO_USE_HTTPS === 'true',
   externalUseSSL: process.env.MINIO_EXTERNAL_ENDPOINT_USE_HTTPS === 'true',
   accessKey: process.env.MINIO_ACCESS_KEY || 'minioadmin',
@@ -98,8 +97,8 @@ export default registerAs('minio', () => ({
 
 Create a `.env` file in your project root:
 ```env
-MINIO_ENDPOINT=your-minio-endpoint
-MINIO_PORT=9000
+MINIO_ENDPOINT=minio:9000
+MINIO_EXTERNAL_ENDPOINT=minio.example.com:9000
 MINIO_USE_HTTPS=false
 MINIO_ACCESS_KEY=your-access-key
 MINIO_SECRET_KEY=your-secret-key
@@ -229,16 +228,15 @@ The module accepts the following configuration options:
 ```typescript
 interface IMinioModuleOptions {
   // Required options
-  endPoint: string;          // MinIO server endpoint
-  port: number;             // MinIO server port
+  endPoint: string;          // MinIO server endpoint (format: "host" or "host:port", e.g., "minio:9000")
   useSSL: boolean;          // Whether to use SSL for connection
   accessKey: string;        // MinIO access key
   secretKey: string;        // MinIO secret key
   urlExpiryHours: number;   // Expiry time for signed URLs in hours
 
   // Optional options
   region?: string;          // MinIO region
-  externalEndPoint?: string; // External endpoint for public access
+  externalEndPoint?: string; // External endpoint for public access (format: "host" or "host:port")
   externalUseSSL?: boolean; // Whether to use SSL for external endpoint
 
   // Bucket configuration
@@ -253,16 +251,15 @@ interface IMinioModuleOptions {
 
 ```typescript
 const minioConfig: IMinioModuleOptions = {
-  endPoint: 'minio.example.com',
-  port: 9000,
+  endPoint: 'minio.example.com:9000', // Port included in endpoint
   useSSL: false,
   accessKey: 'your-access-key',
   secretKey: 'your-secret-key',
   urlExpiryHours: 2,
 
   // Optional settings
   region: 'us-east-1',
-  externalEndPoint: 'public.minio.example.com',
+  externalEndPoint: 'public.minio.example.com:9000', // Port included in endpoint
   externalUseSSL: true,
 
   // Bucket configuration
@@ -283,16 +280,15 @@ const minioConfig: IMinioModuleOptions = {
 
 ```env
 # Required settings
-MINIO_ENDPOINT=minio.example.com
-MINIO_PORT=9000
+MINIO_ENDPOINT=minio:9000
 MINIO_USE_HTTPS=false
 MINIO_ACCESS_KEY=your-access-key
 MINIO_SECRET_KEY=your-secret-key
 MINIO_URL_EXPIRY_HOURS=2
 
 # Optional settings
 MINIO_REGION=us-east-1
-MINIO_EXTERNAL_ENDPOINT=public.minio.example.com
+MINIO_EXTERNAL_ENDPOINT=minio.example.com:9000
 MINIO_EXTERNAL_ENDPOINT_USE_HTTPS=true
 
 # Bucket configuration

src/interfaces/minio-options.interface.ts

@@ -1,11 +1,10 @@
 export interface IMinioModuleOptions {
-  endPoint: string;
-  port: number;
+  endPoint: string; // Format: "host" or "host:port" (e.g., "minio:9000")
   useSSL: boolean;
   accessKey: string;
   secretKey: string;
   region?: string;
-  externalEndPoint?: string;
+  externalEndPoint?: string; // Format: "host" or "host:port" (e.g., "minio.example.com:9000")
   externalUseSSL?: boolean;
   urlExpiryHours: number;
   buckets: {

src/minio.service.ts

@@ -12,10 +12,40 @@ export class MinioService implements OnModuleInit {
   private bucketInitialized = false;
   constructor(@Inject(MINIO_CONFIG) private readonly config: IMinioModuleOptions) {}
 
+  /**
+   * Parses an endpoint string to extract host and port
+   * Supports formats: "host", "host:port", "host:port/path"
+   */
+  private parseEndpoint(endpoint: string): { host: string; port?: number } {
+    // Remove protocol if present
+    const cleanEndpoint = endpoint.replace(/^https?:\/\//, '');
+    
+    // Split by colon to get host and potential port
+    const parts = cleanEndpoint.split(':');
+    
+    if (parts.length === 1) {
+      // No port specified, use default based on SSL
+      return { host: parts[0] };
+    }
+    
+    // Extract port (may have path after it)
+    const portPart = parts[1].split('/')[0];
+    const port = parseInt(portPart, 10);
+    
+    if (isNaN(port)) {
+      // Invalid port, treat as hostname with colon
+      return { host: cleanEndpoint };
+    }
+    
+    return { host: parts[0], port };
+  }
+
   async onModuleInit(): Promise<void> {
+    const { host, port } = this.parseEndpoint(this.config.endPoint);
+    
     this.minioClient = new Minio.Client({
-      endPoint: this.config.endPoint,
-      port: this.config.port,
+      endPoint: host,
+      port: port,
       useSSL: this.config.useSSL,
       accessKey: this.config.accessKey,
       secretKey: this.config.secretKey,
@@ -130,11 +160,12 @@ export class MinioService implements OnModuleInit {
     const accessKey = this.config.accessKey;
     const secretKey = this.config.secretKey;
     const region = this.config.region || 'us-east-1';
-    const externalHost = endPoint;
-    const port = this.config.port;
-
-    // Use host without port for signing
-    const signingHost = port ? `${externalHost}:${port}` : externalHost;
+    
+    // Parse endpoint to get host and port
+    const { host, port } = this.parseEndpoint(endPoint);
+    
+    // Use host with port for signing (if port is specified)
+    const signingHost = port ? `${host}:${port}` : host;
 
     const currentDate = new Date();
     const amzDate = this.getAmzDate(currentDate);
@@ -215,11 +246,11 @@ export class MinioService implements OnModuleInit {
 
   async getPresignedUrl(bucketName: string, objectName: string): Promise<string> {
     if (!this.config.buckets.private.includes(bucketName)) {
+      // For public buckets, return direct URL
       const endpoint = this.config.externalEndPoint || this.config.endPoint;
       const protocol = (this.config.externalUseSSL ?? this.config.useSSL) ? 'https' : 'http';
-      return `${protocol}://${endpoint}${
-        this.config.port ? `:${this.config.port}` : ''
-      }/${bucketName}/${objectName}`;
+      // Endpoint already includes port if specified
+      return `${protocol}://${endpoint}/${bucketName}/${objectName}`;
     }
 
     return await this.calculatePresignedGetUrl(