fix: Fix clippy warnings for all targets

Author: kraigher

vhdl_lang/src/analysis/tests/incremental_analysis.rs

@@ -311,9 +311,8 @@ fn check_analysis_equal(got: &mut DesignRoot, expected: &mut DesignRoot) -> Vec<
 
     // Check that all references are equal, ensures the incremental
     // analysis has cleared refereces
-    use std::iter::FromIterator;
-    let got_refs = FnvHashSet::from_iter(FindAnyReferences::search(got).into_iter());
-    let expected_refs = FnvHashSet::from_iter(FindAnyReferences::search(expected).into_iter());
+    let got_refs: FnvHashSet<_> = FindAnyReferences::search(got).into_iter().collect();
+    let expected_refs: FnvHashSet<_> = FindAnyReferences::search(expected).into_iter().collect();
     let diff: FnvHashSet<_> = got_refs.symmetric_difference(&expected_refs).collect();
     assert_eq!(diff, FnvHashSet::default());
 

vhdl_lang/src/config.rs

@@ -372,7 +372,7 @@ lib1.files = [
         )
         .unwrap();
         let mut libraries: Vec<&str> = config.iter_libraries().map(|lib| lib.name()).collect();
-        libraries.sort();
+        libraries.sort_unstable();
         assert_eq!(libraries, &["lib1", "lib2"]);
 
         let lib1 = config.get_library("lib1").unwrap();

vhdl_lang/src/syntax/tokens/tokenstream.rs

@@ -332,12 +332,7 @@ mod tests {
         let code = Code::new("a begin for + ;");
         new_stream!(code, stream);
 
-        assert!(stream
-            .skip_until(|ref k| match k {
-                Plus => true,
-                _ => false,
-            })
-            .is_ok());
+        assert!(stream.skip_until(|ref k| matches!(k, Plus)).is_ok());
         assert_eq!(stream.peek().map(|t| t.map(|t| t.kind)), Ok(Some(Plus)));
     }
 }