Copy named entities into extended region.

Author: kraigher

vhdl_lang/src/analysis/declarative.rs

@@ -275,7 +275,7 @@ impl<'a> AnalyzeContext<'a> {
             TypeDefinition::ProtectedBody(ref mut body) => {
                 body.type_reference.clear_reference();
 
-                match parent.lookup_extended(&type_decl.ident.item.clone().into()) {
+                match parent.lookup_immediate(&type_decl.ident.item.clone().into()) {
                     Some(visible) => {
                         let is_ok = match visible.clone().into_non_overloaded() {
                             Ok(ent) => {

vhdl_lang/src/analysis/design_unit.rs

@@ -223,7 +223,7 @@ impl<'a> AnalyzeContext<'a> {
 
         unit.entity_name.set_reference_pos(Some(entity.pos()));
 
-        let mut root_region = Region::extend(&entity.result().root_region, None);
+        let mut root_region = Region::with_parent(&entity.result().root_region);
         self.analyze_context_clause(&mut root_region, &mut unit.context_clause, diagnostics)?;
         let mut region = Region::extend(&entity.result().region, Some(&root_region));
 
@@ -266,7 +266,7 @@ impl<'a> AnalyzeContext<'a> {
 
         unit.ident.set_reference_pos(Some(package.pos()));
         // @TODO make pattern of primary/secondary extension
-        let mut root_region = Region::extend(&package.result().root_region, None);
+        let mut root_region = Region::with_parent(&package.result().root_region);
         self.analyze_context_clause(&mut root_region, &mut unit.context_clause, diagnostics)?;
 
         let mut region = Region::extend(&package.result().region, Some(&root_region));

vhdl_lang/src/analysis/named_entity.rs

@@ -199,23 +199,6 @@ impl NamedEntity {
         }
     }
 
-    /// Return a duplicate declaration of the previously declared named entity
-    pub fn is_duplicate_of<'a>(&self, prev: &'a Self) -> bool {
-        if self.is_overloaded() && prev.is_overloaded() {
-            return false;
-        }
-
-        match prev.kind {
-            // Everything expect deferred combinations are forbidden
-            NamedEntityKind::DeferredConstant if self.kind.is_non_deferred_constant() => {}
-            _ => {
-                return true;
-            }
-        }
-
-        false
-    }
-
     /// Strip aliases and return reference to actual named entity
     pub fn as_actual(&self) -> &NamedEntity {
         match self.kind() {