Fix misspelled minimum

Author: kraigher

vhdl_lang/src/analysis/analyze.rs

@@ -206,7 +206,6 @@ impl<'a> AnalyzeContext<'a> {
         };
 
         if let Some(std_library) = self.get_library(&self.std_sym) {
-            // @TODO add warning for missing standard library
             region.make_potentially_visible(None, std_library);
 
             let standard_pkg_data = self.expect_standard_package_analysis()?;

vhdl_lang/src/analysis/implicits.rs

@@ -34,26 +34,30 @@ impl ImplicitVec {
     pub fn iter(&self) -> impl Iterator<Item = Arc<NamedEntity>> + '_ {
         self.0.iter().filter_map(|weak_ent| weak_ent.upgrade())
     }
+
+    pub unsafe fn push(&self, ent: &Arc<NamedEntity>) {
+        raw_mut(&self.0).push(Arc::downgrade(ent));
+    }
 }
 
 #[derive(Default)]
 pub struct ImplicitsBuilder<T>(Arc<T>);
 
 impl<T> ImplicitsBuilder<T> {
-    #[allow(clippy::mut_from_ref)]
-    unsafe fn raw_mut(&self) -> &mut T {
-        let ptr = self.0.as_ref() as *const T as *mut T;
-        &mut *ptr
-    }
-
     pub fn inner(&self) -> Implicits<T> {
         Implicits(self.0.clone())
     }
 }
 impl ImplicitVecBuilder {
     pub fn push(&self, ent: &Arc<NamedEntity>) {
         unsafe {
-            self.raw_mut().push(Arc::downgrade(ent));
+            raw_mut(&self.0).push(Arc::downgrade(ent));
         }
     }
 }
+
+#[allow(clippy::mut_from_ref)]
+unsafe fn raw_mut<T>(arc: &Arc<T>) -> &mut T {
+    let ptr = arc.as_ref() as *const T as *mut T;
+    &mut *ptr
+}

vhdl_lang/src/analysis/named_entity.rs

@@ -43,22 +43,24 @@ pub enum Type {
 
 impl Type {
     pub fn implicit_declarations(&self) -> impl Iterator<Item = Arc<NamedEntity>> + '_ {
+        self.implicits().into_iter().flat_map(|imp| imp.iter())
+    }
+
+    pub fn implicits(&self) -> Option<&ImplicitVec> {
         match self {
-            Type::Array { ref implicit, .. } => Some(implicit.iter()),
-            Type::Enum(ref implicit, _) => Some(implicit.iter()),
-            Type::Integer(ref implicit) => Some(implicit.iter()),
-            Type::Physical(ref implicit) => Some(implicit.iter()),
-            Type::File(ref implicit) => Some(implicit.iter()),
-            Type::Access(.., ref implicit) => Some(implicit.iter()),
+            Type::Array { ref implicit, .. } => Some(implicit),
+            Type::Enum(ref implicit, _) => Some(implicit),
+            Type::Integer(ref implicit) => Some(implicit),
+            Type::Physical(ref implicit) => Some(implicit),
+            Type::File(ref implicit) => Some(implicit),
+            Type::Access(.., ref implicit) => Some(implicit),
             Type::Incomplete(..)
             | Type::Interface
             | Type::Protected(..)
             | Type::Record(..)
             | Type::Subtype(..)
             | Type::Alias(..) => None,
         }
-        .into_iter()
-        .flatten()
     }
 
     pub fn describe(&self) -> &str {
@@ -541,7 +543,7 @@ impl std::cmp::PartialEq for NamedEntity {
 }
 
 // A named entity that is known to be an object
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 pub struct ObjectEnt {
     pub ent: Arc<NamedEntity>,
 }
@@ -582,7 +584,7 @@ impl ObjectEnt {
 }
 
 // A named entity that is known to be a type
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 pub struct TypeEnt(Arc<NamedEntity>);
 
 impl TypeEnt {

vhdl_lang/src/analysis/names.rs

@@ -7,6 +7,7 @@ use std::sync::Arc;
 // Represent a resolved name which can be either a
 // 1. NonObject such as a library or design unit
 // 2. Object such a direct reference to an object or some kind of index, slice or selected name
+#[derive(Debug)]
 pub enum ResolvedName {
     NonObject(Arc<NamedEntity>),
     Type(TypeEnt),