Skip to content

Commit 3e4ed3e

Browse files
authored
Merge pull request #136 from VRGuild/136-refactor-evaluation-sending
[DS-refactor-evaluation-sending] 평가 완료되지 않은 Dev들만 보내는 로직으로 변경
2 parents 68b83a0 + c98c9af commit 3e4ed3e

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

src/main/java/com/mtvs/devlinkbackend/user/query/controller/EpicDevQueryController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public ResponseEntity<DevSingleResponseDTO> findDevByUserId(
4848
return ResponseEntity.ok(devSingleResponseDTO);
4949
}
5050

51-
@Operation(summary = "Epic 계정으로 Dev 전체 Pagination 조회")
51+
@Operation(summary = "Epic 계정으로 평가되지 않은 Dev 전체 Pagination 조회")
5252
@ApiResponses(value = {
5353
@ApiResponse(responseCode = "200", description = "성공적으로 조회됨"),
5454
@ApiResponse(responseCode = "401", description = "잘못된 토큰")

src/main/java/com/mtvs/devlinkbackend/user/query/repository/DevViewRepository.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.springframework.data.domain.Page;
55
import org.springframework.data.domain.Pageable;
66
import org.springframework.data.jpa.repository.JpaRepository;
7+
import org.springframework.data.jpa.repository.Query;
78
import org.springframework.stereotype.Repository;
89

910
import java.util.List;
@@ -19,4 +20,11 @@ public interface DevViewRepository extends JpaRepository<Dev, Long> {
1920
List<Dev> findDevsByDevEmail(String devEmail);
2021

2122
Page<Dev> findAllBy(Pageable pageable);
23+
24+
@Query("""
25+
SELECT d FROM Dev d WHERE EXISTS (
26+
SELECT sc FROM SkillCategoryInfo sc WHERE sc.dev = d AND sc.isEvaluated = false
27+
)
28+
""")
29+
Page<Dev> findAllWithUnevaluatedSkillCategory(Pageable pageable);
2230
}

src/main/java/com/mtvs/devlinkbackend/user/query/service/EpicDevViewService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public DevSingleResponseDTO findDevByUserId(Long userId) {
4040

4141
public DevPagingResponseDTO findAllDevsWithPagination(int page) {
4242
Pageable pageable = PageRequest.of(page, PAGE_SIZE, Sort.by("createdAt").descending());
43-
Page<Dev> devPage = devViewRepository.findAllBy(pageable);
43+
Page<Dev> devPage = devViewRepository.findAllWithUnevaluatedSkillCategory(pageable);
4444
List<NicknameAndDevInfoDTO> data = devPage.getContent().stream().map(dev -> {
4545
User user = userViewRepository.findById(dev.getUserId()).orElse(null);
4646
if(user == null)

0 commit comments

Comments
 (0)