-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
app: backendTask implementation touches the backendTask implementation touches the backendapp: frontendTask implementation touches the frontendTask implementation touches the frontendapp: workerTask implementation touches the workerTask implementation touches the workertype: enhancementEnhancement to an existing featureEnhancement to an existing feature
Description
Currently, the create_variants_for_score_set job in the variant_processing/creation.py uses a try/except block to manage the processing state of the associated ScoreSet. This logic is redundant with the responsibilities of the JobManager, which is already designed to handle job state, error handling, and context updates. The map_variants_for_score_set job follows a similar pattern.
We should:
- Refactor the jobs to delegate all processing state management to the JobManager.
- Remove redundant try/except logic for setting ScoreSet.processing_state and related fields.
- Remove redundant try/except logic for setting ScoreSet.mapping_state and related fields.
- Ensure that all error handling, state transitions, and context updates are handled through the JobManager interface.
- Update front end components to pull state from job status.
- Update tests to reflect the new state management flow.
This will improve cohesion, reduce duplication, and ensure that job and resource state are managed consistently across the worker system.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
app: backendTask implementation touches the backendTask implementation touches the backendapp: frontendTask implementation touches the frontendTask implementation touches the frontendapp: workerTask implementation touches the workerTask implementation touches the workertype: enhancementEnhancement to an existing featureEnhancement to an existing feature